Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbcKGLve convert rfc822-to-8bit (ORCPT ); Mon, 7 Nov 2016 06:51:34 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:51560 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbcKGLvc (ORCPT ); Mon, 7 Nov 2016 06:51:32 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: "David S. Miller" , netdev , LKML , Mason , Andrew Lunn Subject: Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions References: <581CD1AF.6030300@laposte.net> <581CD210.5060206@laposte.net> <58205103.4090208@laposte.net> Date: Mon, 07 Nov 2016 11:51:27 +0000 In-Reply-To: <58205103.4090208@laposte.net> (Sebastian Frias's message of "Mon, 7 Nov 2016 11:01:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 27 Sebastian Frias writes: > Hi M?ns, > > On 11/05/2016 01:58 PM, M?ns Rullg?rd wrote: >>> if (gigabit) { >>> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII) >>> + if (phy_interface_is_rgmii(phydev)) >>> mac_mode |= RGMII_MODE; >>> >>> mac_mode |= GMAC_MODE; >> >> As I said before, this part can/should be applied separately, although >> personally I probably wouldn't have bothered adding a single-use variable. > > It was for consistency with other functions that use 'phydev', but I don't > mind making the changes. > > Just to be clear, when you say "can/should be applied separately", do you > mean that this patch should not be part of a series, and that I should split > the series into separate patches? I meant that this change should be made regardless of the others and can be done separately if desired. -- M?ns Rullg?rd