Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbcKGMBH (ORCPT ); Mon, 7 Nov 2016 07:01:07 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36621 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbcKGMBE (ORCPT ); Mon, 7 Nov 2016 07:01:04 -0500 Date: Mon, 7 Nov 2016 13:00:27 +0100 From: Thierry Reding To: Christophe JAILLET Cc: airlied@linux.ie, swarren@wwwdotorg.org, gnurou@gmail.com, jonathanh@nvidia.com, treding@nvidia.com, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/tegra: dpaux: Fix error handling Message-ID: <20161107120027.GE28616@ulmo.ba.sec> References: <20161028090945.11573-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="so9zsI5B81VjUb/o" Content-Disposition: inline In-Reply-To: <20161028090945.11573-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 45 --so9zsI5B81VjUb/o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2016 at 11:09:45AM +0200, Christophe JAILLET wrote: > 'devm_pinctrl_register()' returns an error pointer or a valid handle. So > checking for NULL here is pointless and can never trigger. >=20 > Check the returned value with IS_ERR instead and propagate this value as > done in the other functions which call 'devm_pinctrl_register()' >=20 > Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") >=20 > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry --so9zsI5B81VjUb/o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJYIGzYAAoJEN0jrNd/PrOhI2UP/j4EmLh7ZP9DT1pWEL3CSTXI rAuy26S6W2+qoMMDfjcOspcVdbjZfN2jL+keiWY36cPuuEfsAWd8oeVVGYYypxzl syl0hgSnm3GgY8KpEnoZHTrylmJK4eiHrD+HrZfs7TOnl8OooF2/9jNDJQH/WVzQ twGe32xMxxTVowdgdDwFw5eevcziN+OUS1PanoVs35D0ndkPbc4ayiUveiDCoBZg NxRx/skn6hS4V2xkbAikM3BDxTY67KH2TrNly9tg9li0UHkx4J2pZag2Tik6yO5v 5sWPHIYpqq/X5mdE2NuBRqanl1GXpXN9Qii0/aYfszdbYDHwKHSUm4Fjutk8+2si kwG5XhOxRSwmthwnbZ5k5C/iIt5J4fh7sS7n6myjKkBrqQuVAOwKrUTUyWKXUIvs hni2slNUJ1S+6Hr1mg4BmUJOffucf4m0nDJjm6VMG6PsuzRY2Ftjyrfby088rda3 9Pm/QJPMKR5nNjZew9OlEyj/KsPgu9jf10c+2HYcYRQ+ytzrj0mTU+rAiN13uoEm HkzoHgoKCnb0+/YqEN1y80eAvddlFjgScwZ9WgTQn4/Nvea+CSLKJ9ltSRFfSMXI pwWLw2FBQQbcQfd+wSKFQciGbtygAuhraL4wKu+aOvm1Irx1Pjj46DW+GWpP6sik shCSNJVLzhw8Kb4g9rh/ =sMnB -----END PGP SIGNATURE----- --so9zsI5B81VjUb/o--