Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbcKGMva (ORCPT ); Mon, 7 Nov 2016 07:51:30 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:33723 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcKGMv2 (ORCPT ); Mon, 7 Nov 2016 07:51:28 -0500 MIME-Version: 1.0 In-Reply-To: References: <20160918141311.17140-1-contact@paulk.fr> <1474395433.1215.23.camel@paulk.fr> From: Alexandre Courbot Date: Mon, 7 Nov 2016 21:51:06 +0900 Message-ID: Subject: Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply To: Jon Hunter Cc: Paul Kocialkowski , Linux Kernel Mailing List , Thierry Reding , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephen Warren Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA7CpYcB031209 Content-Length: 2131 Lines: 61 On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter wrote: > > On 20/09/16 19:17, Paul Kocialkowski wrote: >> * PGP Signed by an unknown key >> >> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : >>> On 18/09/16 15:13, Paul Kocialkowski wrote: >>>> >>>> This enables the GPU node for tegra124 nyan boards, which is required to >>>> get graphics acceleration with nouveau on these devices. >>>> >>>> Signed-off-by: Paul Kocialkowski >>>> --- >>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> index dab9509..225ca77 100644 >>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> @@ -42,6 +42,12 @@ >>>> }; >>>> }; >>>> >>>> + gpu@0,57000000 { >>>> + status = "okay"; >>>> + >>>> + vdd-supply = <&vdd_gpu>; >>>> + }; >>>> + >>>> serial@70006000 { >>>> /* Debug connector on the bottom of the board near SD card. >>>> */ >>>> status = "okay"; >>>> @@ -214,7 +220,7 @@ >>>> regulator-always-on; >>>> }; >>>> >>>> - sd6 { >>>> + vdd_gpu: sd6 { >>>> regulator-name = "+VDD_GPU_AP"; >>>> regulator-min-microvolt = <650000>; >>>> regulator-max-microvolt = >>>> <1200000>; >>>> >>> >>> Looks good to me. I see the following error when booting but looking at the >>> code appears to be benign. Thierry, Alex, is this normal/okay? >> >> I have the same messages and asked Alexandre about them the other day. He told >> me that it looks normal. > > Ok great. Hopefully, Alex can ACK then. Apologies for the (very) delayed reply. Yes, the messages you are seeing are part of the normal probe sequence on Tegra. So this looks good to me. Acked-by: Alexandre Courbot