Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbcKGMxD (ORCPT ); Mon, 7 Nov 2016 07:53:03 -0500 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:60698 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbcKGMxB (ORCPT ); Mon, 7 Nov 2016 07:53:01 -0500 Message-ID: <1478523175.29112.7.camel@tiscali.nl> Subject: Re: [PATCH 1/2] s390: delete unneeded #include from facilities_src.h From: Paul Bolle To: Masahiro Yamada , Martin Schwidefsky , linux-s390@vger.kernel.org Cc: Christian Borntraeger , Heiko Carstens , linux-kernel@vger.kernel.org Date: Mon, 07 Nov 2016 13:52:55 +0100 In-Reply-To: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> References: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 21 On Sun, 2016-11-06 at 12:45 +0900, Masahiro Yamada wrote: > The header facilities_src.h is only included from gen_facilities.c > and the tool is compiled with the following extra options: > > HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE) > > Please note $(LINUXINCLUDE) is expanded into build options including: > > -include $(srctree)/include/linux/kconfig.h > > So, the Makefile always forces the tool to include kconfig.h, i.e., > the #include directive in the header is redundant. As far as I can see the only kernel header that gen_facilities.c is actually interested in is autoconf.h. (autoconf.h will be included via in kconfig.h.) So it seems the odd $(LINUXINCLUDE) variable in that Makefile could be replaced with something like:     -include $(srctree)/include/generated/autoconf.h Paul Bolle