Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753091AbcKGNAV convert rfc822-to-8bit (ORCPT ); Mon, 7 Nov 2016 08:00:21 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:5697 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbcKGNAR (ORCPT ); Mon, 7 Nov 2016 08:00:17 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Sun, 06 Nov 2016 16:59:45 -0800 Subject: Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply To: Alexandre Courbot , Thierry Reding References: <20160918141311.17140-1-contact@paulk.fr> <1474395433.1215.23.camel@paulk.fr> CC: Paul Kocialkowski , Linux Kernel Mailing List , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephen Warren From: Jon Hunter Message-ID: Date: Mon, 7 Nov 2016 13:00:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.21.132.110] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2325 Lines: 72 Thierry, On 07/11/16 12:51, Alexandre Courbot wrote: > On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter wrote: >> >> On 20/09/16 19:17, Paul Kocialkowski wrote: >>> * PGP Signed by an unknown key >>> >>> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : >>>> On 18/09/16 15:13, Paul Kocialkowski wrote: >>>>> >>>>> This enables the GPU node for tegra124 nyan boards, which is required to >>>>> get graphics acceleration with nouveau on these devices. >>>>> >>>>> Signed-off-by: Paul Kocialkowski >>>>> --- >>>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> index dab9509..225ca77 100644 >>>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> @@ -42,6 +42,12 @@ >>>>> }; >>>>> }; >>>>> >>>>> + gpu@0,57000000 { >>>>> + status = "okay"; >>>>> + >>>>> + vdd-supply = <&vdd_gpu>; >>>>> + }; >>>>> + >>>>> serial@70006000 { >>>>> /* Debug connector on the bottom of the board near SD card. >>>>> */ >>>>> status = "okay"; >>>>> @@ -214,7 +220,7 @@ >>>>> regulator-always-on; >>>>> }; >>>>> >>>>> - sd6 { >>>>> + vdd_gpu: sd6 { >>>>> regulator-name = "+VDD_GPU_AP"; >>>>> regulator-min-microvolt = <650000>; >>>>> regulator-max-microvolt = >>>>> <1200000>; >>>>> >>>> >>>> Looks good to me. I see the following error when booting but looking at the >>>> code appears to be benign. Thierry, Alex, is this normal/okay? >>> >>> I have the same messages and asked Alexandre about them the other day. He told >>> me that it looks normal. >> >> Ok great. Hopefully, Alex can ACK then. > > Apologies for the (very) delayed reply. > > Yes, the messages you are seeing are part of the normal probe sequence > on Tegra. So this looks good to me. > > Acked-by: Alexandre Courbot Can you pick this one up for v4.10 as well? Cheers Jon -- nvpublic