Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258AbcKGOHC (ORCPT ); Mon, 7 Nov 2016 09:07:02 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:54274 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203AbcKGOG6 (ORCPT ); Mon, 7 Nov 2016 09:06:58 -0500 Subject: Re: [PATCH 2/6] clk: stm32f4: SDIO & 48Mhz clock management for STM32F469 board To: Daniel Thompson , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Stephen Boyd , Nicolas Pitre , Arnd Bergmann , References: <1478523943-23142-1-git-send-email-gabriel.fernandez@st.com> <1478523943-23142-3-git-send-email-gabriel.fernandez@st.com> <45a332b6-5170-9ae3-8d5e-c5f827c3edea@linaro.org> CC: , , , , , , , From: Gabriel Fernandez Message-ID: <5954f521-91ea-b415-99e9-8a73abb88bcb@st.com> Date: Mon, 7 Nov 2016 15:06:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <45a332b6-5170-9ae3-8d5e-c5f827c3edea@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-07_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2592 Lines: 73 Hi Daniel, On 11/07/2016 02:55 PM, Daniel Thompson wrote: > On 07/11/16 13:05, gabriel.fernandez@st.com wrote: >> From: Gabriel Fernandez >> >> In the stm32f469 soc, the 48Mhz clock could be derived from pll-q or >> from pll-sai-p. >> >> The SDIO clock could be also derived from 48Mhz or from sys clock. >> >> Signed-off-by: Gabriel Fernandez >> --- >> drivers/clk/clk-stm32f4.c | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c >> index 7641acd..dda15bc 100644 >> --- a/drivers/clk/clk-stm32f4.c >> +++ b/drivers/clk/clk-stm32f4.c >> @@ -199,7 +199,7 @@ struct stm32f4_gate_data { >> { STM32F4_RCC_APB2ENR, 8, "adc1", "apb2_div" }, >> { STM32F4_RCC_APB2ENR, 9, "adc2", "apb2_div" }, >> { STM32F4_RCC_APB2ENR, 10, "adc3", "apb2_div" }, >> - { STM32F4_RCC_APB2ENR, 11, "sdio", "pll48" }, >> + { STM32F4_RCC_APB2ENR, 11, "sdio", "sdmux" }, > > I'm confused. How do the "sdmux" clock come to exist on STM32F429? > "sdmux" only exist on STM32F469 (struct stm32f4_gate_data stm32f469_gates[]) BR Gabriel > >> { STM32F4_RCC_APB2ENR, 12, "spi1", "apb2_div" }, >> { STM32F4_RCC_APB2ENR, 13, "spi4", "apb2_div" }, >> { STM32F4_RCC_APB2ENR, 14, "syscfg", "apb2_div" }, >> @@ -940,6 +940,10 @@ static struct clk_hw *stm32_register_cclk(struct >> device *dev, const char *name, >> "no-clock", "lse", "lsi", "hse-rtc" >> }; >> >> +static const char *pll48_parents[2] = { "pll-q", "pllsai-p" }; >> + >> +static const char *sdmux_parents[2] = { "pll48", "sys" }; >> + >> struct stm32f4_clk_data { >> const struct stm32f4_gate_data *gates_data; >> const u64 *gates_map; >> @@ -1109,6 +1113,18 @@ static void __init stm32f4_rcc_init(struct >> device_node *np) >> goto fail; >> } >> >> + if (of_device_is_compatible(np, "st,stm32f469-rcc")) { >> + clk_hw_register_mux_table(NULL, "pll48", >> + pll48_parents, ARRAY_SIZE(pll48_parents), 0, >> + base + STM32F4_RCC_DCKCFGR, 27, 1, 0, NULL, >> + &stm32f4_clk_lock); >> + >> + clk_hw_register_mux_table(NULL, "sdmux", >> + sdmux_parents, ARRAY_SIZE(sdmux_parents), 0, >> + base + STM32F4_RCC_DCKCFGR, 28, 1, 0, NULL, >> + &stm32f4_clk_lock); >> + } >> + >> of_clk_add_hw_provider(np, stm32f4_rcc_lookup_clk, NULL); >> return; >> fail: >> >