Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932243AbcKGOMA (ORCPT ); Mon, 7 Nov 2016 09:12:00 -0500 Received: from up.free-electrons.com ([163.172.77.33]:48592 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932125AbcKGOL7 (ORCPT ); Mon, 7 Nov 2016 09:11:59 -0500 Date: Mon, 7 Nov 2016 15:11:46 +0100 From: Maxime Ripard To: Sean Paul Cc: Russell King - ARM Linux , Daniel Vetter , David Airlie , Thomas Petazzoni , Boris Brezillon , Linux Kernel , DRI mailing list , Hans de Goede , Chen-Yu Tsai , Laurent Pinchart , Linux ARM Kernel Subject: Re: [PATCH 0/5] drm/sun4i: Handle TV overscan Message-ID: <20161107141146.vremdlwdizzejwzd@lukather> References: <20161018092422.GJ1041@n2100.armlinux.org.uk> <20161018100349.qm2f554oiwyjwrsi@lukather> <20161031084233.GS1041@n2100.armlinux.org.uk> <20161103090106.dq2bn4z7m2hzhi53@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="axprtwrogxhpbgrw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3383 Lines: 90 --axprtwrogxhpbgrw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sean, On Thu, Nov 03, 2016 at 03:11:26PM -0600, Sean Paul wrote: > On Thu, Nov 3, 2016 at 3:01 AM, Maxime Ripard > wrote: > > Hi Russell, > > > > On Mon, Oct 31, 2016 at 08:42:34AM +0000, Russell King - ARM Linux wrot= e: > >> On Tue, Oct 18, 2016 at 12:03:49PM +0200, Maxime Ripard wrote: > >> > The first one is that this overscanning should be reported by the > >> > connector I guess? but this is really TV specific, so we need one way > >> > to let the user tell how the image is displayed on its side, and we > >> > cannot really autodetect it, and this needs to be done at runtime so > >> > that we can present some shiny interface to let it select which > >> > overscan ratio works for him/her. > >> > >> See xbmc... they go through a nice shiny setup which includes adjusting > >> the visible area. From what I remember, it has pointers on each corner > >> which you can adjust to be just visible on the screen, so xbmc knows > >> how much overscan there is, and xbmc itself reduces down to the user > >> set size. > > > > Yes. And that is an XBMC only solution, that doesn't work with the > > fbdev emulation and is probably doing an additional composition to > > scale down and center their frames through OpenGL. > > > > We might not have a GPU in the system, and we might not even have an > > entire graphic stack on top either, so I don't think fixing at the > > user-space level is a good option (especially since we already have an > > overscan property in DRM). > > >=20 > Hi Maxime, > I took a quick look at the first 2 patches in the series and they look > good at first glance. I have them in my queue to review more > carefully. Yes, the first one is pretty scary. If it can ease your review, I made a bunch of unittests to test that code. It's pretty hacky (basically a copy of some kernel structures and the new logic to parse the command line), but it should test it with a significant number of cases: http://code.bulix.org/4lnlk7-107122?raw It's pretty straightforward to compile, you just have to link against cmocka. > Can you explain why you can't fix this by specifying a new mode with > big porches (as Russell suggested)? I'll reply to his mail. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --axprtwrogxhpbgrw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYIIufAAoJEBx+YmzsjxAgRkwQALLuVKL991VxTxZ4ALGOx0ri f8z3/j/GlVtrnPRdWanxHSS48mXoJ15+dPdm1YqbwfRYnKmzWB4Ckf2OJA4zBWL1 gjv/EqTN4CzdNRcGw3BhY90yN7ETlqvN7kkSkhco5qACzyG77xrWvZGJ/kLgt5UG Wwq5JscGeqT5PotVq0rLTW2DQWHzJYT39bG+y407HITOrGN4eGU9FaUYSx74m6yg Gtz7/8lMjB+IYZwVnVlUkOMV17KKUptECs35vIntElJhB2SAHMJUj4Y++PrlTq3j JyLwxaDZ+45zmHc+2uBqcLXWkSnMGl+/FOV78zC62gB+UZV3ADOXPE2OiQ9qGZ1c nN1VTtFhAns7JQae3IFDGP+6zBkT3R3WiGixebGRIxbvJlA9Er2uJdg0EROZcnjM MJzlQoP50TANesGve861hJPSf6dRJ3aMQwSf8Ved8EX1NNYEBe1th7iByxUwfbSh BSIWQrcSVCYyNFscUV+X2vUsS5luhfmbxY2UB+InrW0ujZrXQbaiUq9yaXBuWw7+ maXo841grbmoplgcnHrIESJp6kTnBJxBzx+38HUJ78HJu2QAD1vyjkKsAFN3T0jB uxZ9ydpbJFu3+EEVGcTaY5ayMRfZZoD6FmEM5wfxgqK2d5c7YBDlEG2f2fWY1cX3 54cAVO8vqeXSzPwgUSIt =13nw -----END PGP SIGNATURE----- --axprtwrogxhpbgrw--