Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932205AbcKGPFM (ORCPT ); Mon, 7 Nov 2016 10:05:12 -0500 Received: from mail-by2nam03on0066.outbound.protection.outlook.com ([104.47.42.66]:59793 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752104AbcKGPFE (ORCPT ); Mon, 7 Nov 2016 10:05:04 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [PATCH] net: xgbe: use new api ethtool_{get|set}_link_ksettings To: Philippe Reynes , References: <1478440624-23565-1-git-send-email-tremyfr@gmail.com> CC: , From: Tom Lendacky Message-ID: Date: Mon, 7 Nov 2016 08:31:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478440624-23565-1-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR13CA0014.namprd13.prod.outlook.com (10.168.161.152) To CY4PR12MB1144.namprd12.prod.outlook.com (10.168.164.136) X-MS-Office365-Filtering-Correlation-Id: 9b691dca-451b-4ca5-fc00-08d4071ac965 X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;2:0+8tHEWDtsSK0xB4GBfilj2E7HNh4ZZKLTnJ3b0rOf0azyfqotRRipWAHGzaTvGxtbr7cLlWuV0JfIODdwxWeyEEC1OeDgslFSHvT5Bj0ydnbChQiW05ZQakrN2gTLKBI1cxVT60Y1JRYEmbe6DAkaZJn2qfQ1ww7u6gGV89HuR6R1HrGgyHyEKdM8wWqrrx7d7C4CHV110+ILWi00mtNA==;3:sY5a7ZoHyNr/C6V9pcV5AU449xa5NEauXr6guBym40Z41Y80gxCduf1htEdP0/RGJX4DRXV0fPA8IRR47819+1h2HoFjdXsEnNTvLBQOZhGZr34uxcKqFdCF7rM+w31TPt+hwu3e8TFm46LSEhll1g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1144; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;25:XbHh3o5xBozsekKF6s9KNlc5gAYTJpcObPLB5IOmDGQLF+xk1XNoD4T4wu2j6X92NBT+cVKmanSPV7NOTOFGbnoU/m2FqEF2EmXBpiVJmgq4vVIr05ypNwd7O8yyWybmE+0pbC82yYmrwRrFfzWfIGHBvvNafDeI5h8HcicUKPZ2tKVNgFKj4niNnMvboLnJTn28edE0VnpwLiehYPhZOzH8TgyO379yxqEQM558vNKePl0R7X02/Vnm+qkSV5a8Ofs7ZOIddS9NiqIXKhdUDn1kEbT0x3yh+S6IH/9UONOYALSUwdBmjsqg+8MUzcsFEUYMYj82nCEHRfbhlv5marwHPFjHyZSm2T2Fzk0N6S9GY04QTs+YIMQqi9niwCC9PTKFJbpyraXrvGy87WrS8DI4V8ENL5QGYm1x3A7C+pqTKUwGLhUhAvEVlhnjD0iBr0G/ewx5d5XKx10ZGuLk8rC09JxX3UOimLB81uD5c46JQwSKwu51CBPxtSEDKDlukeClrQ5PUvmzzrf7MJH/UIxpmzcdMU1paBYsnBMxprNkL+arjJk31qxEWM8W/Gye4fyi6VjlQlzsV5PaGHhFhM+obag4eQfmzq42J2oAkXWbUwU+vzTs7zjVuo99uhW/tepV7RedpTDjuPQNlonkXHceDUseqQj/3IQ+pqe2P41D+NEsBPWNJ4nWSyN1WwRHm1QVb1XgVvg7C3jK9BvSow== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;31:VK43li7Jt+2BA1eMyZA8yGxH3mY1IKl5kqTESGoEh9tS4gHOyRe9lt+OeGx/3kJF1qLMArDCC99CTnR2VdicDR3IUgyHwkfRjXq6+Kraem6fmiwcB8RwCes4ia4A4yUagmpO954jABIg3Ss0qItxjSymMtoBCH8EF+P0SQdT9gESdVFWLgielXmHsD2fdolRqhWnZsIzF7y8A/srt4MVHWklQoJvMnB7p9tzK53l/jzhgeGIYtU7c/1wvakjQ5wq;20:bS8Y7E3CstuIhqFoQp3cVABoUHXn4owcH51m7X8zTFwReVcC+EMSnu3TUWbRvG9+lMxoyl7micZkzuRroPnVlNtbcLNJJUlSgc+D4+y+ltIbkolKshcEMDdPOyGJ12IdZ25A8Yt5a/QIYu8y5oyfFcamBAG/LE4NrA50+5Gb9xiVaqwbTGeVv28qIiRzK0FSlkTZiyxWD1Q6r16l9L0hveupsXJGWmh7Ywq+WoPamgirO2XQDhPLoaU8rslmMG/GDHWr5ViQF1+ip9Ceihn1m1ABsA7VoM4xotqOMLahCtJu1VRNloCsTpty7Q8RpdTJVwr1Qtrg+Vz9W294OOmN1OfhWcH7zabrrIdteGfDGkneExktELWNfvKjiz3vuLtdMIzeis+DlaG0/L/bDDCokoTy/kdsD1VqclHzepNwVTm03zJo5ji3i4WYUMtLSidQAIL58qKt6KKMspfJS5BYBG5xbLrRfZGhHQsjju6gnnj6+CgZPt2ljGgH26p6FCV0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CY4PR12MB1144;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1144; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;4:EwSNdOkWl3C3h9E5pE485HVmJ/5yDkFRvmU7m5TKPsFVHyIpveV7jG4Oo7+H7oV8Uq2N94QMgRmmKVofINygeDXSjV7gyAh2UvsWTmhk+7Pr8fjY18Yr6lM1k3p5RA6I3iOeQeXw6KEKhx07mXC+/CAvCJvyq0l1Y8JXKFuLkdhKankRSlX9mRgDdfEryJs99tL/iJEy7tkTTyTojQKrrRz2MqrZxn042goD1JOCW9R5fWf+NyiE2PiRd1XQZ4gOCMphHY47kkDziKyyeULg1viED1zibIvL6G2wpVYYaqp9EPzbTUYId3OLn3pql/4PgiT1egwhED9gJaifN/T+yNfGQY6w7Xeys4/OnaKebnV71k4DaALw8cM9Q/xGxyeL9ufEZaqhHfC8RHb6LvQ0k7NjqhWW3lQMIoIj8s1HlbCDHd6s/wMgc86rrs0NxbUbYb0/F1EXqMnicPjD3B068Q== X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(377454003)(189002)(5001770100001)(65826007)(4001350100001)(42186005)(105586002)(19580405001)(81166006)(6116002)(3846002)(47776003)(189998001)(33646002)(81156014)(8676002)(19580395003)(97736004)(92566002)(77096005)(54356999)(64126003)(6666003)(106356001)(76176999)(50986999)(5660300001)(65806001)(66066001)(230700001)(50466002)(65956001)(83506001)(2950100002)(305945005)(4326007)(2906002)(36756003)(586003)(7846002)(7736002)(23746002)(31696002)(101416001)(68736007)(31686004)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1144;H:[10.236.18.82];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1144;23:mRe6cLIqx2LWYLrRf48lvYf8Shq7Lc/fTc43e?= =?Windows-1252?Q?29TWKdV39wla4DDRtBa9RIGhaL742vDM1ONOJsoFCXR/F9TnOKTYynUs?= =?Windows-1252?Q?iNxXHRzbuKaXWxbcbafOBC3gKroTsfgra7aoaCHIyWUIxU2M+k8z54Bs?= =?Windows-1252?Q?sulCu6zgE4JAbjpDeJ6dK96zwis5IAA2S72vk4jk0sSnvdrhe714Yf4a?= =?Windows-1252?Q?PxXm13tPLF4uZrS3P333pWUTOaLMGFqsLcGFdXA8AYvOQpe3CdQbXsg0?= =?Windows-1252?Q?wvouXA8/V+hhcg4tn7taAR3p28OlX9+C45zH6nxIlZ9g6ZRccozwkW+0?= =?Windows-1252?Q?8/DR7/vzO+hqtTd4FHtxggZu0Eqq+MQE4jiu5vrZhVxDyHmFBofFsqDW?= =?Windows-1252?Q?dHsMiGqVbUtFpOExglygCIrVWy09zb1ABRQl9y86wcxZiME9LYPOSSuA?= =?Windows-1252?Q?Btwsy6VqFzzyGBhc3umjloXfRLwVT4s8KtscmAslERdE5RsK2poewC9t?= =?Windows-1252?Q?b4TQMlVSZ3PhHyV2yny+kPoJvwHs9A/nWFb2pVlGI33M06mriGkT/3aF?= =?Windows-1252?Q?UjTzEUo1XX5qefQhrKayBbzHO2c2Sc1epBK0EXqBHIso/UeDSITB25S/?= =?Windows-1252?Q?vGM8z8NhFMpMucIdzYifBtGy54XeZzxSgR/Jm4KWDEsruaG8stZvgmkr?= =?Windows-1252?Q?LleP3wDC9s2LHC30dSHDj4zsmILek1+OzmhljRlELTgesdnkwftDqcNZ?= =?Windows-1252?Q?ST6SpJ6jjC+VGb+UkpdxTltICo73ZHi4F7Q/xSNqTWUSAnHl0rqI8imH?= =?Windows-1252?Q?MHTt0Mp9+JkhQlfdNm2lTv7tVLDoM1O5uAusvCScIOPMVvdghNTqJpFP?= =?Windows-1252?Q?kSQbMhkdgY1m3Ac+bHfZ71VY45CvOLa3mq+0OCuJdl6ZpMZ71/n8INoT?= =?Windows-1252?Q?D2g5/dDhsxT85P2vy2gg9/U61GlKEGfKGUN/HRi+B9J+KyuPQtR6my8j?= =?Windows-1252?Q?aIr4vQGWn/tV5vBOMY6JZtbVScrEvuZVc0a8Gj/SfgoqEBMtg2SH+rjA?= =?Windows-1252?Q?P6bY24UvsObUomp9CkCQIgoI5Afcv0EGI/mLid8Im5GdIi42H9JI/w38?= =?Windows-1252?Q?l6NAZABYdAofchWVs7lZkKbv4vr0zwKxt/8zNiGoWYR7itKjsOmh2lpq?= =?Windows-1252?Q?WOJlJjubgrA2sdYCBe7ZT4W2mt5BZ6C/zxeQxN8VDutfwwO1o68tlU5M?= =?Windows-1252?Q?DooCYKBDgA0tEyCKt4w0ywwU6Iwssbew/F/efEwAEE/sF8mNy0Wk6BJF?= =?Windows-1252?Q?BIp45mpB4OrrsCpR0UjNPI/LKiPSijiFbvG/AbLW68Nb+MZ2KxwJgAJa?= =?Windows-1252?Q?BgNTqe+l0lFDq9jbrnbn28gzjAmxArb+/EAWOt0my6iEVzMr774Sak?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;6:A7WNuUgBVmdfnBRfhYcWApQA6olSjJ8J9up+HGl4KZpNQeq9KoZDRuufiQxvftL4Uii+WArBtgD9w/B1K1f20GFdb8a4UT+ZrfESkPjU0DbALMlNLLX2uu6xL/q+ip5sWnPdVG+6+fTyPkjyCRh0q9Lex/7fG1e4umKa/I7Aokr5n79teHUw9PQLdupebMg4nSK1NGskH03Sg0RAryvAzk0fW+K5GhTYBUfayePcXf15iOLh6KuBbAdH/1GigEHsnHr7U4RLka9rVjfZrXsJA7EDKFRLnjCqhe7VWWsDG0UTWjloJ9gPhtDhI6ljtaI/WQyhYM6aZZ17h6BVjKe2CdxW3CB6XdVrAtES2n/qR7k=;5:mnZHMyUsr6+WjA77zJfHqYdvGasQkmgI2cjy3zOKSt1ppGGHbjwmPvxTujHhBXX9r2cq8lsRsAS7+CRdELyQ+wjLchzs6w77NYlshWKudRl+/PwLntMDAZSiV0LXHt3K/vjlZ0f3n3tq4rorToYRyZLdSTUtSTbxxtQTQ/2RPLs=;24:yZORuUcFu30CZ/sC+7x7MuujtR/0RJb1jQN/sk2sj5PmdJDuadLsur4fBV7F79ixUjnsfCEWu/cFA08Bu3ipWceCwy6ldR2QR+Fvi/GpNv4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;7:yfX5IPRjEo/sBAvCTRquNHVTzcALfhE84kDNn3HTNXddzoL9Fl3PMYibJZX2ZXCcUCjt/fWNFisTAEbABDF6qPonf2VksUbdwducutYqmVOO1vwVgvANOTxSaioSjRonW4JirU7LbXigioAcRgq3nVMxc+5OwgueZkDGV0cO9ykbWOTrBnQTZF77xZOLulkfDgscChzxa6E7xb8GAOn5bdyKts+Jd/JupU/BnPL5Uk7xubfHvI7Mmg0YgUf745GGt8a5vaPf4izd47mkJhYSSQpYmhImf4iglagEGEGj9B4tSwDkM9oePK76oIj5uQng/ZQlYCB0tzgrRRYlLIBa2QoNt8yN+95m6TNA6e8xPmQ=;20:3/aK+yyLFXvh9VN5vi+cF1fRT4cIJDYnCQ+kffiQHVIDcz3zoC5bWqp0DquyxzxzHMjYlZgxCdN7V1wrhxVHnp/JUfkSYpSsRVYYv01/UrKI0Bn5Er1jAUUl+blg/u2Mee2kc/QbfDPn7i0j6svaNqWqfloJIx1sS5KUvlEsOGn1M3IEt7VSYH/Zx27VvhzR6OiZHvl/u1t+GTbGveTKtEypxNI/vMNVdwMNo2PvyLuBJGXiArLn51X35fsqT+Kj X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 14:31:39.3429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 16 On 11/06/2016 07:57 AM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Acked-by: Tom Lendacky > --- > drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 68 ++++++++++++++------------ > 1 files changed, 37 insertions(+), 31 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c > index 46c959b..920566a 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c