Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbcKGPeq (ORCPT ); Mon, 7 Nov 2016 10:34:46 -0500 Received: from mout02.posteo.de ([185.67.36.66]:37554 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753065AbcKGPeo (ORCPT ); Mon, 7 Nov 2016 10:34:44 -0500 Subject: Re: [BUG][REGRESSION] mangled display since -rc1 To: Jani Nikula , Thorsten Leemhuis , Joerg Roedel References: <5d11d88ae7d77ce1c0adbc9e6ffc7633@posteo.de> <20161031152136.GA3473@suse.de> <6e267e2b-ddd2-8768-8fb5-72a1781c4cc1@posteo.de> <20161031215454.GB3473@suse.de> <79A6D00F-A07B-49B8-84D6-FB80E9D181FB@posteo.de> <87k2cnjuan.fsf@intel.com> <27a0c8f9-0f1f-fa99-fc96-6c6fcba4bfe4@leemhuis.info> <0f63c442-29c0-bcf7-2f0b-a2733eb7794b@posteo.de> <87zilb8zp9.fsf@intel.com> Cc: Linux kernel , torvalds@linux-foundation.org, daniel.vetter@intel.com From: Martin Kepplinger Message-ID: Date: Mon, 7 Nov 2016 16:34:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <87zilb8zp9.fsf@intel.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3176 Lines: 96 Am 2016-11-07 um 09:24 schrieb Jani Nikula: > On Sun, 06 Nov 2016, Martin Kepplinger wrote: >> I did not file a bug in bugzilla yet. I haven't given up that we can fix >> this here before the release. I've ignored it the last few days though. > > You say it like filing the bug report and having the bug fixed are > mutually exclusive things... > > Pretty please? It's easier for us to direct folks at the bug, with > history and logs in one place. I realize only Daniel and me were Cc'd > here, not intel-gfx list. > > Also, please double check your bisect. Not sure why the finger points at > i915 when the bisect points at iommu merge. > > > BR, > Jani. > > Chris Clayton wrote off list and the mentioned patch fixes the problem for me too, as it does for others. I hope it make it's way into the tree soon: -------- Weitergeleitete Nachricht -------- Betreff: Fwd: Re: Redraw issues on i915 on 4.9-rc Datum: Mon, 7 Nov 2016 13:48:14 +0000 Von: Chris Clayton An: martink@posteo.de Hi Martin. I can't contact you through LKML because I'm not subscribed, but I've been working with Chris Wilson, one of the Intel DRM developers to analyse and fix the corruption. We've got a patch that fixes it for me and Norbert who also reported the problem. The patch is at the bottom of this message. Hope it helps. Chris -------- Forwarded Message -------- Subject: Re: Redraw issues on i915 on 4.9-rc Date: Mon, 7 Nov 2016 09:25:59 +0000 From: Chris Wilson To: Chris Clayton CC: Norbert Preining On Mon, Nov 07, 2016 at 09:16:38AM +0000, Chris Clayton wrote: > Hello again. > > I wasn't at all happy about the last bisect I did, so I've run it again and this time spent at least 30 minutes using my > system before marking a kernel as good. I've also noticed that when I boot a bad kernel, the graphics associated with > three of my desktop icons do not get drawn, so that helps. > > The outcome of the bisection is: > > a61007a83a4671da77210790997d5c8c92ed87ea is the first bad commit > commit a61007a83a4671da77210790997d5c8c92ed87ea > Author: Chris Wilson > Date: Thu Aug 18 17:17:02 2016 +0100 > > drm/i915: Fix partial GGTT faulting That's just the enabling patch, everything was meant to be in place by then. Oh noes, care to try: diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index c642385bb236..a52b40bbac6f 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1837,7 +1837,7 @@ int i915_gem_fault(struct vm_area_struct *area, struct vm_fault *vmf) /* Use a partial view if it is bigger than available space */ chunk_size = MIN_CHUNK_PAGES; if (i915_gem_object_is_tiled(obj)) - chunk_size = max(chunk_size, tile_row_pages(obj)); + chunk_size = roundup(chunk_size, tile_row_pages(obj)); memset(&view, 0, sizeof(view)); view.type = I915_GGTT_VIEW_PARTIAL; -- Chris Wilson, Intel Open Source Technology Centre