Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933516AbcKGSyS (ORCPT ); Mon, 7 Nov 2016 13:54:18 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:49021 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932586AbcKGSyR (ORCPT ); Mon, 7 Nov 2016 13:54:17 -0500 Subject: Re: [PATCH] ARC: [plat-eznps] remove IPI clear from SMP operations To: Noam Camus References: <1478504061-4668-1-git-send-email-noamca@mellanox.com> CC: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: Vineet Gupta Message-ID: Date: Mon, 7 Nov 2016 10:54:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478504061-4668-1-git-send-email-noamca@mellanox.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 38 On 11/06/2016 11:34 PM, Noam Camus wrote: > From: Noam Camus > > Generic IRQ mechanism is already acknowledge the IPI IRQ. > Doing this once more time in IPI handler is not needed. Changelog can be improved ! Generic IRQ mechanism can't ack the irq. The NPQ irqchip driver does this for all irqs already - so no special handling is needed for IPI in NPS case. -Vineet > > Signed-off-by: Noam Camus > --- > arch/arc/plat-eznps/smp.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/arch/arc/plat-eznps/smp.c b/arch/arc/plat-eznps/smp.c > index 5e901f8..56a4c85 100644 > --- a/arch/arc/plat-eznps/smp.c > +++ b/arch/arc/plat-eznps/smp.c > @@ -140,16 +140,10 @@ static void eznps_init_per_cpu(int cpu) > mtm_enable_core(cpu); > } > > -static void eznps_ipi_clear(int irq) > -{ > - write_aux_reg(CTOP_AUX_IACK, 1 << irq); > -} > - > struct plat_smp_ops plat_smp_ops = { > .info = smp_cpuinfo_buf, > .init_early_smp = eznps_init_cpumasks, > .cpu_kick = eznps_smp_wakeup_cpu, > .ipi_send = eznps_ipi_send, > .init_per_cpu = eznps_init_per_cpu, > - .ipi_clear = eznps_ipi_clear, > };