Subject: Re: [PATCH] arm/vdso: introduce vdso_mremap hook
To: Russell King - ARM Linux <linux@armlinux.org.uk>
References: <20161101172214.2938-1-dsafonov@virtuozzo.com>
 <20161107182734.GL1041@n2100.armlinux.org.uk>
CC: <linux-kernel@vger.kernel.org>, <0x7f454c46@gmail.com>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        Christopher Covington <cov@codeaurora.org>,
        "Andy Lutomirski" <luto@amacapital.net>,
        Oleg Nesterov <oleg@redhat.com>, "Will Deacon" <will.deacon@arm.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Pavel Emelyanov <xemul@virtuozzo.com>
From: Dmitry Safonov <dsafonov@virtuozzo.com>
Message-ID: <0d3a03e0-43ad-1e6f-a065-17e5bfdd92f4@virtuozzo.com>
Date: Mon, 7 Nov 2016 21:36:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161107182734.GL1041@n2100.armlinux.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 18:39:40.0397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1737
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 804
Lines: 23

On 11/07/2016 09:27 PM, Russell King - ARM Linux wrote:
> On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
>> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
>> index 53cf86cf2d1a..d1001f87c2f6 100644
>> --- a/arch/arm/kernel/vdso.c
>> +++ b/arch/arm/kernel/vdso.c
>> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
>>  	.pages = &vdso_data_page,
>>  };
>>
>> +static int vdso_mremap(const struct vm_special_mapping *sm,
>> +		struct vm_area_struct *new_vma);
>
> I'd much rather avoid this forward declaration.  Is there any reason the
> function body can't be here?
>

Well, I didn't want it to be in the middle of static file variables -
those looks nice at this moment just on top of the file.
No other than that.

-- 
              Dmitry