Date: Mon, 7 Nov 2016 13:28:09 -0600 (CST)
From: Christoph Lameter <cl@linux.com>
To: Thomas Garnier <thgarnie@google.com>
cc: David Rientjes <rientjes@google.com>,
        Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        Greg Thelen <gthelen@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v2] memcg: Prevent memcg caches to be both OFF_SLAB &
 OBJFREELIST_SLAB
In-Reply-To: <CAJcbSZHaN8zVf4_MdpmofNCY719YfRsRq+PjLR-a+M4QGyCnGw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1611071324380.19249@east.gentwo.org>
References: <1477939010-111710-1-git-send-email-thgarnie@google.com> <alpine.DEB.2.10.1610311625430.62482@chino.kir.corp.google.com> <CAJcbSZHic9gfpYHFXySZf=EmUjztBvuHeWWq7CQFi=0Om7OJoA@mail.gmail.com> <alpine.DEB.2.10.1611021744150.110015@chino.kir.corp.google.com>
 <alpine.DEB.2.20.1611031531380.13315@east.gentwo.org> <CAJcbSZHaN8zVf4_MdpmofNCY719YfRsRq+PjLR-a+M4QGyCnGw@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 25

On Mon, 7 Nov 2016, Thomas Garnier wrote:

> I am not sure that is possible. kmem_cache_create currently check for
> possible alias, I assume that it goes against what memcg tries to do.

What does aliasing have to do with this? The aliases must have the same
flags otherwise the caches would not have been merged.

> Separate the changes in two patches might make sense:
>
>  1) Fix the original bug by masking the flags passed to create_cache
>  2) Add flags check in kmem_cache_create.
>
> Does it make sense?

Sure.

> > I also want to make sure that there are no other callers that specify
> > extraneou flags while we are at it.
> I will review as many as I can but we might run into surprises (quick
> boot on defconfig didn't show anything). That's why having two
> different patches might be useful.

These surprises can be caught later ... Just make sure that the core works
fine with this. You cannot audit all drivers.