Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbcKGUvs (ORCPT ); Mon, 7 Nov 2016 15:51:48 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:53192 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbcKGUvr (ORCPT ); Mon, 7 Nov 2016 15:51:47 -0500 Date: Mon, 7 Nov 2016 21:48:56 +0100 (CET) From: Thomas Gleixner To: "Andrejczuk, Grzegorz" cc: "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "bp@suse.de" , "dave.hansen@linux.intel.com" , "Daniluk, Lukasz" , "Cownie, James H" , "Pan, Jacob jun" , "Luc, Piotr" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v8: 1/4] x86/msr: Add MSR_MISC_FEATURE_ENABLES and PHIR3MWAIT bit In-Reply-To: Message-ID: References: <1477995290-25079-1-git-send-email-grzegorz.andrejczuk@intel.com> <1477995290-25079-2-git-send-email-grzegorz.andrejczuk@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 32 On Fri, 4 Nov 2016, Andrejczuk, Grzegorz wrote: > >>On Tue, 1 Nov 2016, Grzegorz Andrejczuk wrote: > >> > >> +/* Intel Xeon Phi x200 ring 3 MONITOR/MWAIT */ > > > > Oh well. I asked you to make that whole PHI thing go away. > > > > This is a feature which has nothing to do with PHI. It just happens to > > be implemented on PHI. The FEATURES_ENABLES MSR is not at all PHI > > specific. > > It's all about a feature which enables ring 3 mwait/monitor. > > This bit enables ring 3 MONITOR/MWAIT only on Xeon Phi. It is reserved > for other architectures. I think this will be confusing when I remove > PHI. It's reserved for other models simply because they do not implement it. PHI is nothing special and the MSR is not PHI specific at all. It's used for other features on other models, e.g. CPUID faulting (bit 0). That's why PHI got bit 1. Intel has so far been very consistent with MSRs which are implemented on different models and it would be highly surprising if they would use a different MSR/BIT when they bring that ring3 mwait feature to other models than PHI. We make it PHI special when that happens, but for now there is nothing PHI special, except that the only model which implements this is PHI at the moment. Thanks, tglx