Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbcKGWln (ORCPT ); Mon, 7 Nov 2016 17:41:43 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:34638 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbcKGWll (ORCPT ); Mon, 7 Nov 2016 17:41:41 -0500 Date: Mon, 7 Nov 2016 17:41:38 -0500 (EST) From: Nicolas Pitre To: Josh Triplett cc: John Stultz , Michal Marek , Richard Cochran , Paul Bolle , Thomas Gleixner , Edward Cree , netdev@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes In-Reply-To: <20161107223149.pgs5dqtbw5aprow7@jtriplet-mobl2.jf.intel.com> Message-ID: References: <1478556899-2951-1-git-send-email-nicolas.pitre@linaro.org> <1478556899-2951-3-git-send-email-nicolas.pitre@linaro.org> <20161107223149.pgs5dqtbw5aprow7@jtriplet-mobl2.jf.intel.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 560 Lines: 17 On Mon, 7 Nov 2016, Josh Triplett wrote: > [snipping large patch] > > One suggestion that might make this patch easier to review: you might > consider first regenerating the unchanged parser with Bison 3.0.4, then > regenerating it again after the "imply" change. I think that'd > eliminate quite a lot of noise in this patch. I tried that. This made two large patches instead of just one, both equally obscure. So this patch stands on its own, containing changes that are mechanically generated and therefore shouldn't require manual review. Nicolas