Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbcKGXwD (ORCPT ); Mon, 7 Nov 2016 18:52:03 -0500 Received: from ozlabs.org ([103.22.144.67]:45749 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbcKGXv5 (ORCPT ); Mon, 7 Nov 2016 18:51:57 -0500 From: Michael Ellerman To: Laurent Dufour , Christopher Covington , criu@openvz.org, Will Deacon , linux-mm@kvack.org Cc: Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions In-Reply-To: References: <20161101171101.24704-1-cov@codeaurora.org> <20161101171101.24704-6-cov@codeaurora.org> <87oa1vn8lc.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 08 Nov 2016 10:51:56 +1100 Message-ID: <87shr2lug3.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 36 Laurent Dufour writes: > On 04/11/2016 05:59, Michael Ellerman wrote: >> Christopher Covington writes: >> >>> The PowerPC VDSO remap and unmap code was copied to a generic location, >>> only modifying the variable name expected in mm->context (vdso instead of >>> vdso_base) to match most other architectures. Having adopted this generic >>> naming, drop the code in arch/powerpc and use the generic version. >>> >>> Signed-off-by: Christopher Covington >>> --- >>> arch/powerpc/Kconfig | 1 + >>> arch/powerpc/include/asm/Kbuild | 1 + >>> arch/powerpc/include/asm/mm-arch-hooks.h | 28 ------------------------- >>> arch/powerpc/include/asm/mmu_context.h | 35 +------------------------------- >>> 4 files changed, 3 insertions(+), 62 deletions(-) >>> delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h >> >> This looks OK. >> >> Have you tested it on powerpc? I could but I don't know how to actually >> trigger these paths, I assume I need a CRIU setup? > > FWIW, tested on ppc64le using a sample test process moving its VDSO and > then catching a signal on 4.9-rc4 and using CRIU on top of 4.8 with > sightly changes to due minor upstream changes. > > Reviewed-by: Laurent Dufour > Tested-by: Laurent Dufour Thanks, in that case: Acked-by: Michael Ellerman cheers