Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbcKHBTV (ORCPT ); Mon, 7 Nov 2016 20:19:21 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35058 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbcKHBTK (ORCPT ); Mon, 7 Nov 2016 20:19:10 -0500 Date: Mon, 7 Nov 2016 13:18:49 -0800 From: Olof Johansson To: Christophe JAILLET Cc: jun.nie@linaro.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ARM: zx: Fix error handling Message-ID: <20161107211849.GB2106@localhost> References: <20161030081010.14735-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161030081010.14735-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 411 Lines: 13 On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote: > 'devm_ioremap_resource()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > 'return -EIO;' could also be turned into 'return PTR_ERR(pcubase);' in > order to propagate the error value. Applied to fixes-non-critical. Thanks! -Olof