Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbcKHBmi (ORCPT ); Mon, 7 Nov 2016 20:42:38 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36740 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbcKHBmf (ORCPT ); Mon, 7 Nov 2016 20:42:35 -0500 MIME-Version: 1.0 X-Originating-IP: [209.133.79.5] In-Reply-To: <20161107132127.GE12559@ulmo.ba.sec> References: <1478083719-14836-1-git-send-email-smangipudi@nvidia.com> <20161107132127.GE12559@ulmo.ba.sec> From: Olof Johansson Date: Mon, 7 Nov 2016 17:42:33 -0800 Message-ID: Subject: Re: [PATCH] gpio: tegra186: Add support for T186 GPIO To: Thierry Reding Cc: Linus Walleij , Suresh Mangipudi , Laxman Dewangan , Stephen Warren , Alexandre Courbot , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 26 On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding wrote: > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi wrote: >> >> > Add GPIO driver for T186 based platforms. >> > Adds support for MAIN and AON GPIO's from T186. >> > >> > Signed-off-by: Suresh Mangipudi >> >> Stephen/Thierry/Alexandre: >> Can I get your review on this Tegra thing? > > Can we hold off on this for a bit? I've got my own implementation of > this in my Tegra186 tree because I thought nobody else was working on > it. From a brief look they seem mostly similar but there are a couple > of differences that I need to take a closer look at (and do some more > intensive testing on). Be careful about discouraging other developers internally from participating upstream, Thierry. Please don't become a bottleneck for your company's contributions. Rewriting stuff on your own isn't a scalable model. -Olof