Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbcKHBum (ORCPT ); Mon, 7 Nov 2016 20:50:42 -0500 Received: from conssluserg-04.nifty.com ([210.131.2.83]:64489 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcKHBug (ORCPT ); Mon, 7 Nov 2016 20:50:36 -0500 X-Greylist: delayed 165891 seconds by postgrey-1.27 at vger.kernel.org; Mon, 07 Nov 2016 20:50:36 EST DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com uA81oW2d010341 X-Nifty-SrcIP: [209.85.213.179] MIME-Version: 1.0 In-Reply-To: <1478523175.29112.7.camel@tiscali.nl> References: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> <1478523175.29112.7.camel@tiscali.nl> From: Masahiro Yamada Date: Tue, 8 Nov 2016 10:50:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] s390: delete unneeded #include from facilities_src.h To: Paul Bolle Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, Christian Borntraeger , Heiko Carstens , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 53 Hi Paul, 2016-11-07 21:52 GMT+09:00 Paul Bolle : > On Sun, 2016-11-06 at 12:45 +0900, Masahiro Yamada wrote: >> The header facilities_src.h is only included from gen_facilities.c >> and the tool is compiled with the following extra options: >> >> HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE) >> >> Please note $(LINUXINCLUDE) is expanded into build options including: >> >> -include $(srctree)/include/linux/kconfig.h >> >> So, the Makefile always forces the tool to include kconfig.h, i.e., >> the #include directive in the header is redundant. > > As far as I can see the only kernel header that gen_facilities.c is actually > interested in is autoconf.h. (autoconf.h will be included via in kconfig.h.) > So it seems the odd $(LINUXINCLUDE) variable in that Makefile could be > replaced with something like: > -include $(srctree)/include/generated/autoconf.h This would break O= build because autoconf.h is a generated file. Rather, it should be -include $(objtree)/include/generated/autoconf.h I thought of this at first, but I was not quite sure if the file path include/generated/autoconf.h is a guaranteed interface. Basically, now we are supposed to include autoconf.h via kconfig.h. So, I thought $(LINUXINCLUDE) is a more stable interface than specifying the exact path to autoconf.h I doubt that nobody would try to change it, but it is just two my cents. Anyway, arch/x86/boot/Makefile already referenced the path to autoconf.h So, if you want to change it, I will not oppose to it. -- Best Regards Masahiro Yamada