Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050AbcKHEEf (ORCPT ); Mon, 7 Nov 2016 23:04:35 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33661 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbcKHEEc (ORCPT ); Mon, 7 Nov 2016 23:04:32 -0500 Date: Tue, 8 Nov 2016 09:34:29 +0530 From: Viresh Kumar To: Stratos Karafotis Cc: "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , LKML Subject: Re: [Resend][PATCH] cpufreq: conservative: Decrease frequency faster when the timer deferred Message-ID: <20161108040429.GI21030@vireshk-i7> References: <973ac1ee-ff65-9190-762d-13deefdccba2@semaphore.gr> <20161107061234.GD21030@vireshk-i7> <8acc17f0-d88f-19f6-f7a3-4c66cd65ab96@semaphore.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8acc17f0-d88f-19f6-f7a3-4c66cd65ab96@semaphore.gr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 22 On 07-11-16, 19:27, Stratos Karafotis wrote: > Yes, it could be done only when we decrease frequency. But I thought that maybe > this is against conservative governor principle. > > I initially observed this issue on a Snapdragon 808 using conservative on the > big cluster (A57). The CPU seemed to remain in high frequencies for > long time (even 10 seconds) before it returns to min. > > So, most probably the load after the deferred period is completely unrelated to > the previous one. If we apply this heuristic only when the frequency will be > decreased (and having in mind that we copy the load value from the previous > period), IMHO I'm afraid that the conservative will be still more aggressive even > from ondemand governor. The deferred period here is actually the time for which the CPU was idle and not doing anything. And I am not sure why we should be worrying about increasing the frequency steps for the period for which the CPU was idle. -- viresh