MIME-Version: 1.0
In-Reply-To: <20161107150712.d7b26fc6cf6c403b85f9e36a@linux-foundation.org>
References: <1478553075-120242-1-git-send-email-thgarnie@google.com>
 <1478553075-120242-2-git-send-email-thgarnie@google.com> <20161107150712.d7b26fc6cf6c403b85f9e36a@linux-foundation.org>
From: Thomas Garnier <thgarnie@google.com>
Date: Mon, 7 Nov 2016 20:22:44 -0800
Message-ID: <CAJcbSZGQEcVtx6BdbSSypEg9qGu8ZFzhiizqPk+Hz71Uc2=NAw@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] mm: Check kmem_create_cache flags are commons
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, Greg Thelen <gthelen@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Michal Hocko <mhocko@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 19

On Mon, Nov 7, 2016 at 3:07 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon,  7 Nov 2016 13:11:15 -0800 Thomas Garnier <thgarnie@google.com> wrote:
>
>> Verify that kmem_create_cache flags are not allocator specific. It is
>> done before removing flags that are not available with the current
>> configuration.
>
> What is the reason for this change?

The current kmem_cache_create removes incorrect flags but do not
validate the callers are using them right. This change will ensure
that callers are not trying to create caches with flags that won't be
used because allocator specific.

It was Christoph's suggestion on the previous versions of the original
patch (the memcg bug fix).

-- 
Thomas