Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbcKHEl3 (ORCPT ); Mon, 7 Nov 2016 23:41:29 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45849 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752388AbcKHEl0 (ORCPT ); Mon, 7 Nov 2016 23:41:26 -0500 Subject: Re: [PATCH v3 1/1] skd_main: use %*ph to dump small buffers To: Andy Shevchenko , Ming Lin , References: <20161022165201.164176-1-andriy.shevchenko@linux.intel.com> From: Jens Axboe Message-ID: <811e7628-42f1-cbd9-35af-d5edeb7908d5@fb.com> Date: Mon, 7 Nov 2016 21:41:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161022165201.164176-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BY2PR08CA021.namprd08.prod.outlook.com (10.141.248.139) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-Office365-Filtering-Correlation-Id: ba0c2aae-6f9a-47c3-0b6d-08d407917aff X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;2:ljZQ0aJSvWUkuFE3w4k1XDgoZSbwq5FMMvzn6iJWl1KoPGaosOt1kpNbbs6izHvZ661lPbQ0OouQOYBQUkyiaUEmv1VMURNk0jnSDu2jBh6rcryS3xYThxqABdnEtT2RsBRoaP2fUmnvwxdQxJZ658NlaG1/bBc8jm+x+vqhyKRzUAKI+2QBnj19fWq+wOKW5pZUTfo3zGcpRNJoc1aO1Q==;3:75cZ1oNxI4vLj1/niZvXsYKTkqvpi4igDdwn3e5qQShgspLV6JD2ZEM+hTT8ElAKrgeUlD/WySUhnyYAoWEU7wDiAV4IZ/d3KHG4svrmEo10stalILsvOztEM2AfzIlBtvQjBCxKRBG0SpPHTGlylw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;25:u2zsvVDlnmU53BqRO38eN3yUIV4hK0kUTaypUluFl31kwAmH8cbnHRkr7Ue87+G3DPGd4hcSzZNUaEP/sZPogXLBf7G0n97IHmJE5eU9Tpw67F/Wvbr5IHxr5oh+tckPQC6stdGbe0W6PF3+xllRhqKmWucPGenpqbA1gYWSbR9dFjQZ6VPDwwzX0VypSN5uc+m3KGluxsq262sp8iRO5cILdLnjfOqyf2v5Wn0sMDYZ+VXZ3RbiZFU7ooY4srsZi35p8BpLJriOOHrUlpQQ38g45fb/pYfzfz7G5yTW8l5j/PwxFTSSUPMGlxCdRqPs39gJckDYgumFKkoV/FRVS2ZyO1a2PhdF08PPMl67w9iOHJiGLc8GEP4e+Pwtv+aXU7ia3MQMO/SxEwrUfgtT/Es2qiz0TJY3fPIyuDesjPx10tJe99HKNMSDERLXzPtfc3qo38G4BkqVGdpz9snGoeu/oYqxXZlur17aMEfIfo+HFAVBgKiVSzAbrL37ENTWeOQJUp0GM5WRkWY2BLUlf735wANmmHARP0oXWqfE3yGKwOF1GILgBBj0QsvuD8d7xv1iMcuBLmmCZ4gAfIOcI9Wj7LlMzGzSagTSuB49RLNuYgpRnDMzHO+iCQzL130us8klQCjvYFBBHcrd0VyE9tr8QOcfZAMWNtVs1mEB1Z1onxTrsnJR3Vdytq3dszSwQqHM6IgeIrFLofQ+UE24kQ== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:NQHLiQt9pQz+LLheyRa1hnusqXlEntgEk25erzlYcEUr0+gl3v2UCxybDFkvHxzvdRngYBDXHSMchBlsCITO2+O+dvZrwh7liEGLcJ30m09GwKD6RCpkaKbkhb8jW631f+1KDtiUmlfPtFTSWLWsPeMU8rrwWfj3BsL8+GOrAdQt4aajO7EYfSleiTXeW2xLGU2xT+sVQwvKgz5e2qed8h5Hqgs5NOudDfRBRxdWFeFpULS6KGDrwFAYnKgQpHVg8qZ3rbv4B1Lk2+/UEYr/wTdmiByAT82/tVdHuqyTXO4=;20:OJ0tazyJo6beoEzAvnchV8fxZXW2pds4hGgBllL5n5Zsf5Xld9bM2TpbSrWkrN5NeioOVWwSqPFgESFGNZuVOnsgNpwpoof/Ej1HOhZlpvJtx8a+HkNjJ7Cx7e4gMeMSyqVoQmO2Bfg2mx9VwwGNuJrSph6d+Ysefle82Rtjz+M=;4:hpChYg1SRafGFX3UNdT02FxRmcKjcMiTs1tlkaWzoE5FSkL1gbPUxMcroU8RYxEKFOuyQHasec1sb3iqLkGArz5og9qGPBisZg1eHO/6/zEfAYnb87zvsi61bKB4QQQSCcUKdzekZcQRVyEOord8L6ZkgDaqLYa+DXqqwRv+t/qvSI7qBJC7HjN1NjjV+VxKhvClfn5iOenfBh4oDK2BI9tpInrB8lDfP4LmZiOQmYUJOC03PC08EWPEI2BGbjdeHRJZx4mkBVdizBr4Wz6TH3fqtK22RGOebY63vtEDsNj8Ha19TMoIGSUceSrhn3XV3WaooQHE1MUU1XN3JPxWo/4hU1I0uA3EfVG4C2642jcwyMGa4UbruUNyRDeLz83FXP05oGSTwfUs7/9Vn1vE+1hpKB09Mv2HqLNKddWZY4m7ixNEnhQfSAUDj+BpD5NY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Forefront-PRVS: 01208B1E18 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(377454003)(189002)(6666003)(42186005)(6116002)(31686004)(2906002)(76176999)(65956001)(31696002)(86362001)(50986999)(230700001)(54356999)(65806001)(106356001)(101416001)(66066001)(47776003)(92566002)(68736007)(305945005)(117156001)(77096005)(5660300001)(8676002)(23746002)(7736002)(107886002)(33646002)(81156014)(50466002)(4001350100001)(65826007)(97736004)(5001770100001)(7846002)(189998001)(105586002)(64126003)(3846002)(586003)(36756003)(83506001)(81166006)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1189;23:CSo6162pgekSsF77Rvv2Rq0SBqq3C1QpieOSg?= =?Windows-1252?Q?4IaR8s45K/hdBUeweDNDxZsnyBISH2WPvJzuGIgbu4x6QKtcY4b1JUNl?= =?Windows-1252?Q?Wc5auLnKGB0sxciKF3gu9yaTmd+23RvTNGfOqcoJIEOENnDidYOY5OS+?= =?Windows-1252?Q?HhNzy7ln7r7kkUFbs32dLS/uPWogFsyw0aObPHFVyDldcRI16JKQNdoi?= =?Windows-1252?Q?eFfB9BuIzmgvCCAk5Fa8TBcw5claSyXY3u8h8hdH9IwKKdsCSIrVp/jR?= =?Windows-1252?Q?HJV3VOEFDJmVgciOFU4AhM+dQ0yWMNFvVei/vkxvWajDukvG6qxXwHhC?= =?Windows-1252?Q?8+M0nHDvgNgsvv+nxSOuZPfZSfIi6TutEcKN48Q6lEWuF8GBhxYTcyJN?= =?Windows-1252?Q?s2JOQw4tgxe2JvAMJxsXg7xGhhw7w6z+OWRozCwhqZ2INPLtNGBM0YnL?= =?Windows-1252?Q?B9BMIitNJKLTPdNjk1shOYl4Nmf+MC5q0q4++wEfRiiOxMBrdDwSrBvp?= =?Windows-1252?Q?YNXQ0JR+ntE2c1mlozug1UeqDvr+xjjmkuwxgOwzhmYkWq9d8B/VhOBR?= =?Windows-1252?Q?4jZzJdvTkQSvMNuXvgANFkmdEuXmI4AxwBvaSCv3R3cjy4Y4bipQ726r?= =?Windows-1252?Q?B3YSYC2a0noVcnJEzuTYTaxF7i4bTfaGIrml9PotrEIuFVVhbgO6miOj?= =?Windows-1252?Q?6Wil4XgOAJ/Cg8CYuaImI20rCUr/GEVYBwI/bTJU50fAdSXGee7PaQlt?= =?Windows-1252?Q?eZqUnSsUEHCf8LboeDdOLjVktiIAaG1eEvMCZriS+qf9qpZn6sotcuWy?= =?Windows-1252?Q?gfen//Z2BSzFSr/lUJxE6I5UA0h2TRmdBAX/hhVNAz0b76gh72SGrxEt?= =?Windows-1252?Q?kR2uvgH1fB0crDdwScdh4tVSnC5E7LqIleDxvb7hhLQL7Rqjc7uDAFAc?= =?Windows-1252?Q?SHi5VBXR4G56AauuuCciCKClpRDOInkOuG0G1LfTfngoD6zEqXyOQRKI?= =?Windows-1252?Q?Ui4wftCI97vEDecx9hSsaWN9VVa1YqHdO6s6ttCasJVL3Zu1gVZAc2eS?= =?Windows-1252?Q?ZyGuG75JhuYYE2i8yUuPK8RoO3ifqvq9/m6NJbyPfROPoUQK795C2vG8?= =?Windows-1252?Q?ihyjHsle4YBmR+eMPT+Cyv7SvpvA7WHI2Ev5kPO/3t5Ns+w1tvQDL0bQ?= =?Windows-1252?Q?7fmOVyf7g6cMUefrpBPemlsCeiox6M/NaDmA5CepSz/T8DLSZvqYrH2f?= =?Windows-1252?Q?pJuex3dk4Nvlh2D5WMVCrcRQSdsEibruxPp+jjHNXo60PgUGMbRYugT+?= =?Windows-1252?Q?V6kRpW0IuXb/t7ca8vAbzpMxMWCvg0z47vkMmsSLwsa96PSWPK+aygQn?= =?Windows-1252?Q?Ro1KEd25wVdMWzkLRZWr4iuTc8ZZq5/TQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:T6gn2tIrBwAAWdHEvU58XDTCmbOOvQMEcy25+d2bul/N2k0e/z19whR9UjGWx+zrKOFNot7/PmX2iT4Mt/v95/Hleg7KgvEghl66APXt92mn2bYeyYeL+OzIzeGWGbpVJ/75eA05S+rJnT0FMBI3/lwiJL6r78bKjORA0aA/o+UVPQS8zcX4AOO4beIFEK3eQRHxXFe/jEuTk67tQw+y4g5iksqIz0j9L8WOfoPVTVRV5KnqoQ3mWTBqWET/6LzlLmOCyI5pKcR7Hnc7CCViGPSXZ0Of8JafN0f54KmmSIu7nNUT6Wv6x0Jf1XVTtXC2;5:4yNR6fG22YWsa2zKLxGGWuVNCotdbXfONL0LEMQugOeM2L66Jq8N7mCKGSDOhyF2CEPiBVKn9prv8IV0o0/apHIrq5gSV/vJ8QYBXHRII37xEx9naonF3HYVpLXOMA+U4+FwEP/Uxya2J4UgNSWncg==;24:5VylZx7SeHu6Em2NJQ+kdTzwQuCi6oyWSfGYm6eNY9/BWIVdObJtxmDPV27uE5GHZ93RUEFoO4vzIxRNKWWaH3HAtAN0R/8BAAM6f2Jdr3Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:cRDcpHQywjkWZKjqkLlEKjo7brROvXagwCJCpdXq6FP08CfbDtxiM4N3bnVoXPpYMRek1GzdCCTBxpWZwdc8mt4sh0cYFWwrYdMJ2RdkHdk4Neq96kd9iBPzYn9fPEAlXTtwdnoSwVRgMtJa3kljwKR/Hq4vRiPewTxmHB9ado7HF9y+2XCpu5D9V4eGwp2V6Vz3TNN8t7RifCCJJ1D8tV+p76T1HRUZ9gbBNT69C8eXaOyWqbjNJH/WLAd6Lf0M1uR2a42AxgROtvmVnVHAan78SFR9Iw2tRr9OAPr+tapKSK08cdJDlbXJLwbOaxMyvVeeqfxow5D9dgXAbkuMYz814WKOl89ylAK/Y7cznw0=;20:sBlwGhXAkhWQy1qsjsich21P141ZptH9lFgiTdij95w3Pu7kaWZtINsvndNcWVhUsV1P488ipjUBoVPy/uyidvmLoYmeZRYgAxj4U3K092TqCy/2O/djRKAZTBYHJTeAxgnUUsv/ilj1t2oIMPmQvDTDA6Fw+JGMOPuPkE1vHVM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2016 04:41:17.4514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-08_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 317 Lines: 10 On 10/22/2016 10:52 AM, Andy Shevchenko wrote: > Replace custom approach by %*ph specifier to dump small buffers in hex format. > > Unfortunately we can't use print_hex_dump_bytes() here since tha gap is > present, though one familiar with the code may change this. Added (finally) for 4.10, thanks. -- Jens Axboe