Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbcKHIXt (ORCPT ); Tue, 8 Nov 2016 03:23:49 -0500 Received: from www9186uo.sakura.ne.jp ([153.121.56.200]:44196 "EHLO www9186uo.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbcKHIXr (ORCPT ); Tue, 8 Nov 2016 03:23:47 -0500 X-Greylist: delayed 395 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Nov 2016 03:23:19 EST Date: Tue, 8 Nov 2016 17:16:43 +0900 From: Naoya Horiguchi To: Anshuman Khandual Cc: Naoya Horiguchi , linux-mm@kvack.org, "Kirill A. Shutemov" , Hugh Dickins , Andrew Morton , Dave Hansen , Andrea Arcangeli , Mel Gorman , Michal Hocko , Vlastimil Babka , Pavel Emelyanov , Zi Yan , Balbir Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/12] mm: thp: add core routines for thp/pmd migration Message-ID: <20161108081642.GA29855@www9186uo.sakura.ne.jp> References: <1478561517-4317-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1478561517-4317-6-git-send-email-n-horiguchi@ah.jp.nec.com> <58218942.8010608@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <58218942.8010608@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 35 On Tue, Nov 08, 2016 at 01:43:54PM +0530, Anshuman Khandual wrote: > On 11/08/2016 05:01 AM, Naoya Horiguchi wrote: > > This patch prepares thp migration's core code. These code will be open when > > unmap_and_move() stops unconditionally splitting thp and get_new_page() starts > > to allocate destination thps. > > > > Signed-off-by: Naoya Horiguchi > > --- > > ChangeLog v1 -> v2: > > - support pte-mapped thp, doubly-mapped thp > > --- > > arch/x86/include/asm/pgtable_64.h | 2 + > > include/linux/swapops.h | 61 +++++++++++++++ > > mm/huge_memory.c | 154 ++++++++++++++++++++++++++++++++++++++ > > mm/migrate.c | 44 ++++++++++- > > mm/pgtable-generic.c | 3 +- > > 5 files changed, 262 insertions(+), 2 deletions(-) > > > > diff --git v4.9-rc2-mmotm-2016-10-27-18-27/arch/x86/include/asm/pgtable_64.h v4.9-rc2-mmotm-2016-10-27-18-27_patched/arch/x86/include/asm/pgtable_64.h > > index 1cc82ec..3a1b48e 100644 > > --- v4.9-rc2-mmotm-2016-10-27-18-27/arch/x86/include/asm/pgtable_64.h > > +++ v4.9-rc2-mmotm-2016-10-27-18-27_patched/arch/x86/include/asm/pgtable_64.h > > @@ -167,7 +167,9 @@ static inline int pgd_large(pgd_t pgd) { return 0; } > > ((type) << (SWP_TYPE_FIRST_BIT)) \ > > | ((offset) << SWP_OFFSET_FIRST_BIT) }) > > #define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val((pte)) }) > > +#define __pmd_to_swp_entry(pte) ((swp_entry_t) { pmd_val((pmd)) }) > > The above macro takes *pte* but evaluates on *pmd*, guess its should > be fixed either way. Right, I fix it. Thank you very much. - Naoya