Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932937AbcKHJSa (ORCPT ); Tue, 8 Nov 2016 04:18:30 -0500 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:48543 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbcKHJS2 (ORCPT ); Tue, 8 Nov 2016 04:18:28 -0500 Message-ID: <1478596703.29112.42.camel@tiscali.nl> Subject: Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c From: Paul Bolle To: Heiko Carstens Cc: Martin Schwidefsky , Masahiro Yamada , linux-s390@vger.kernel.org, Sascha Silbe , Christian Borntraeger , linux-kernel@vger.kernel.org Date: Tue, 08 Nov 2016 10:18:23 +0100 In-Reply-To: <20161107133807.GB4075@osiris> References: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> <1478403928-20799-2-git-send-email-yamada.masahiro@socionext.com> <20161107070322.GA4075@osiris> <20161107105005.3477a324@mschwide> <1478524386.29112.18.camel@tiscali.nl> <20161107133807.GB4075@osiris> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 46 On Mon, 2016-11-07 at 14:38 +0100, Heiko Carstens wrote: > On Mon, Nov 07, 2016 at 02:13:06PM +0100, Paul Bolle wrote: > > --- /dev/null > > +++ b/arch/s390/include/asm/facilities.h > > @@ -0,0 +1,43 @@ > > +#ifndef __ASM_FACILITIES_H > > +#define __ASM_FACILITIES_H > > + > > +#define FACILITIES_ALS \ > > + _AC(IS_BUILTIN(CONFIG_HAVE_MARCH_Z900_FEATURES), UL) << 0 | /* N3 instructions */ \ > > So, this is wrong. It should be " << 63" to match the existing code. Bother. > > +#define FACILITIES_KVM \ > > + _BITUL(0) | /* N3 instructions */ \ > > + _BITUL(1) | /* z/Arch mode installed */ \ > > + _BITUL(2) | /* z/Arch mode active */ \ > > + _BITUL(3) | /* DAT-enhancement */ \ > > + _BITUL(4) | /* idte segment table */ \ > > + _BITUL(5) | /* idte region table */ \ > > + _BITUL(6) | /* ASN-and-LX reuse */ \ > > + _BITUL(7) | /* stfle */ \ > > + _BITUL(8) | /* enhanced-DAT 1 */ \ > > + _BITUL(9) | /* sense-running-status */ \ > > + _BITUL(10) | /* conditional sske */ \ > > + _BITUL(13) | /* ipte-range */ \ > > + _BITUL(14) /* nonquiescing key-setting */ \ > > + , \ > > + _BITUL(9) | /* transactional execution */ \ > > + _BITUL(11) | /* access-exception-fetch/store indication */ \ > > And this is exactly what I want to avoid: start counting from zero again if > we cross a double word. It _must_ read 73, 75, otherwise this becomes the > unmaintainable and error prone mess we had before. > > I just want a list with bit numbers and the rest must be created > automatically. This sounds like a can of worms. Better keep it closed. Thanks, Paul Bolle