Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbcKHKuL (ORCPT ); Tue, 8 Nov 2016 05:50:11 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49568 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932306AbcKHKuK (ORCPT ); Tue, 8 Nov 2016 05:50:10 -0500 X-ME-Sender: X-Sasl-enc: uixKBf9FGiPGN7mOTesUjncG7PXXnccHvRIluoIpGpAH 1478602208 Date: Tue, 8 Nov 2016 08:50:05 -0200 From: Henrique de Moraes Holschuh To: Lyude Cc: ibm-acpi-devel@lists.sourceforge.net, Daniel Martin , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function Message-ID: <20161108105004.GA8609@khazad-dum.debian.net> References: <1478538633-11450-1-git-send-email-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478538633-11450-1-git-send-email-lyude@redhat.com> X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 17 On Mon, 07 Nov 2016, Lyude wrote: > @@ -3117,6 +3120,34 @@ static const struct tpacpi_quirk tpacpi_hotkey_qtable[] __initconst = { > typedef u16 tpacpi_keymap_entry_t; > typedef tpacpi_keymap_entry_t tpacpi_keymap_t[TPACPI_HOTKEY_MAP_LEN]; > > +static int > +hotkey_init_tablet_mode(void) > +{ Function definiton all in one line, please. Provided that you fix that minor nit, Acked-by: Henrique de Moraes Holschuh -- Henrique Holschuh