Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbcKHMHM (ORCPT ); Tue, 8 Nov 2016 07:07:12 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:36066 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbcKHMHJ (ORCPT ); Tue, 8 Nov 2016 07:07:09 -0500 MIME-Version: 1.0 In-Reply-To: <20161108032941.GC20591@arm.com> References: <22f4d20911e39efa0b8a6f7082d6839b80bb16b0.1476941895.git.panand@redhat.com> <20161108032941.GC20591@arm.com> From: Pavel Labath Date: Tue, 8 Nov 2016 11:58:53 +0000 Message-ID: Subject: Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses To: Will Deacon , Pratyush Anand Cc: Mark Rutland , linux-arm-kernel , linux-kernel@vger.kernel.org, Jan Kratochvil , onestero@redhat.com, Pavel Labath Content-Type: multipart/mixed; boundary=001a114fa6427c7f0e0540c8de5d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1712 Lines: 45 --001a114fa6427c7f0e0540c8de5d Content-Type: text/plain; charset=UTF-8 >> >> /* Do we need to handle the stepping? */ >> if (is_default_overflow_handler(wp)) >> step = 1; >> - >> -unlock: >> - rcu_read_unlock(); >> } >> + if (min_dist > 0 && min_dist != -1) { >> + /* No exact match found. */ >> + wp = slots[closest_match]; >> + info = counter_arch_bp(wp); >> + info->trigger = addr; >> + perf_bp_event(wp, regs); >> + } > > Why don't we need to bother with the stepping in the case of a non-exact > match? Good catch. I think we do. I must have dropped that part somehow. Pratyush, could you include the attached fixup in the next batch? regards, pavel --001a114fa6427c7f0e0540c8de5d Content-Type: text/x-patch; charset=US-ASCII; name="fixup.diff" Content-Disposition: attachment; filename="fixup.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iv9g02fj0 ZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva2VybmVsL2h3X2JyZWFrcG9pbnQuYyBiL2FyY2gvYXJt NjQva2VybmVsL2h3X2JyZWFrcG9pbnQuYwppbmRleCA0MTI1YzIxLi44NTJjNzUzIDEwMDY0NAot LS0gYS9hcmNoL2FybTY0L2tlcm5lbC9od19icmVha3BvaW50LmMKKysrIGIvYXJjaC9hcm02NC9r ZXJuZWwvaHdfYnJlYWtwb2ludC5jCkBAIC03OTMsNiArNzkzLDEwIEBAIHN0YXRpYyBpbnQgd2F0 Y2hwb2ludF9oYW5kbGVyKHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGVzciwKIAkJ aW5mbyA9IGNvdW50ZXJfYXJjaF9icCh3cCk7CiAJCWluZm8tPnRyaWdnZXIgPSBhZGRyOwogCQlw ZXJmX2JwX2V2ZW50KHdwLCByZWdzKTsKKworCQkvKiBEbyB3ZSBuZWVkIHRvIGhhbmRsZSB0aGUg c3RlcHBpbmc/ICovCisJCWlmIChpc19kZWZhdWx0X292ZXJmbG93X2hhbmRsZXIod3ApKQorCQkJ c3RlcCA9IDE7CiAJfQogCXJjdV9yZWFkX3VubG9jaygpOwogCg== --001a114fa6427c7f0e0540c8de5d--