Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933472AbcKHMZq (ORCPT ); Tue, 8 Nov 2016 07:25:46 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35736 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234AbcKHMZI (ORCPT ); Tue, 8 Nov 2016 07:25:08 -0500 From: Johan Hovold To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com Subject: [PATCH 3/3] serial: crisv10: fix invalid user-pointer check Date: Tue, 8 Nov 2016 13:24:55 +0100 Message-Id: <1478607895-23447-4-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1478607895-23447-1-git-send-email-johan@kernel.org> References: <1478607895-23447-1-git-send-email-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 28 Drop invalid user-pointer check from TIOCGSERIAL handler. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Cc: Mikael Starvik Cc: Jesper Nilsson Cc: linux-cris-kernel@axis.com Signed-off-by: Johan Hovold --- drivers/tty/serial/crisv10.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c index 315c84979b18..d4cb6ff52e7a 100644 --- a/drivers/tty/serial/crisv10.c +++ b/drivers/tty/serial/crisv10.c @@ -3214,8 +3214,6 @@ get_serial_info(struct e100_serial * info, * should set them to something else than 0. */ - if (!retinfo) - return -EFAULT; memset(&tmp, 0, sizeof(tmp)); tmp.type = info->type; tmp.line = info->line; -- 2.7.3