Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933480AbcKHMvz (ORCPT ); Tue, 8 Nov 2016 07:51:55 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:51679 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932477AbcKHMvy (ORCPT ); Tue, 8 Nov 2016 07:51:54 -0500 Date: Tue, 8 Nov 2016 13:51:50 +0100 From: Jesper Nilsson To: Johan Hovold Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com Subject: Re: [PATCH 3/3] serial: crisv10: fix invalid user-pointer check Message-ID: <20161108125150.GY30704@axis.com> References: <1478607895-23447-1-git-send-email-johan@kernel.org> <1478607895-23447-4-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478607895-23447-4-git-send-email-johan@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 16 On Tue, Nov 08, 2016 at 01:24:55PM +0100, Johan Hovold wrote: > Drop invalid user-pointer check from TIOCGSERIAL handler. > > A NULL-pointer can be valid in user space and copy_to_user() takes care > of sanity checking. > > Cc: Mikael Starvik Acked-by: Jesper Nilsson > Cc: linux-cris-kernel@axis.com > Signed-off-by: Johan Hovold /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com