Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbcKHOQk (ORCPT ); Tue, 8 Nov 2016 09:16:40 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:34769 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbcKHOQh (ORCPT ); Tue, 8 Nov 2016 09:16:37 -0500 From: Alexey Brodkin To: "noamca@mellanox.com" CC: "linux-kernel@vger.kernel.org" , "Vineet.Gupta1@synopsys.com" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console Thread-Topic: [PATCH v2] ARC: [plat-eznps] set default baud for early console Thread-Index: AQHSOcMg4cvO2nvTzECXF6YnIT+OiaDPDo6AgAABpACAAAB1AA== Date: Tue, 8 Nov 2016 14:15:39 +0000 Message-ID: <1478614492.5131.57.camel@synopsys.com> References: <1478611259-4477-1-git-send-email-noamca@mellanox.com> <1478614041.5131.53.camel@synopsys.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.14.110] Content-Type: text/plain; charset="utf-8" Content-ID: <6D1D16274F1D324DBE8647D56111E4AB@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uA8EGljw007815 Content-Length: 668 Lines: 18 Hi Noam, On Tue, 2016-11-08 at 14:13 +0000, Noam Camus wrote: > > > > From: Alexey Brodkin [mailto:Alexey.Brodkin@synopsys.com]  > > Sent: Tuesday, November 8, 2016 4:08 PM > > > > > Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any. > ... Just fix some typos in log > This line somehow was removed from patch while sending (It is at patch head followed by line with ---) > Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2). Thanks for explanation. IMHO it worth adding that kind of changelog on each next iteration so please keep it in mind next time :) -Alexey