Subject: Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled
 platforms not currently supported
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Luis Oliveira <Luis.Oliveira@synopsys.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        "Ramiro Oliveira" <Ramiro.Oliveira@synopsys.com>
References: <cover.1476462204.git.lolivei@synopsys.com>
 <36f4b1736e36b039af15b13645df0de492f1b6e1.1476462204.git.lolivei@synopsys.com>
 <20161014173014.GA26269@leverpostej> <20161014182045.GA1509@katana>
 <55cc91af-8d24-8aea-f74f-2ef40cd8ea5a@synopsys.com>
 <20161018151706.GA1433@katana>
 <76ab13e9-9aa5-97c3-2328-928bbcef9877@synopsys.com>
 <1477047272.6423.6.camel@linux.intel.com>
CC: Mark Rutland <mark.rutland@arm.com>, <jarkko.nikula@linux.intel.com>,
        <mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <CARLOS.PALMINHA@synopsys.com>
From: Luis Oliveira <Luis.Oliveira@synopsys.com>
Message-ID: <9a3dd667-b8ac-7116-a855-538f3e91572f@synopsys.com>
Date: Tue, 8 Nov 2016 14:18:44 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1477047272.6423.6.camel@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1418
Lines: 50

Hi,


As you suggested I will split the drivers. I am thinking of doing 5 patches:

- factor out master() parts

- separate Master part to i2c-designware-master.c (changes in i2c-designware-core.c)

- enable Slave part to i2c-designware-slave (changes in i2c-designware-core.c)

- glue drivers and device bindings

- cleaning


Regards,

Luis

On 21-Oct-16 11:54, Andy Shevchenko wrote:
> On Fri, 2016-10-21 at 10:56 +0100, Luis Oliveira wrote:
>> Since practically 90% of the code is shared between master and slave,
>> I was
>> thinking if it will be acceptable to use the same driver for both but
>> differentiate the master/slave mode by the compatible strings.
> It might be possible to split like other drivers do:
>
> 1. Core part (i2c-designware-core.c)
> 2. Master part (i2c-designware-master.c)
> 3. Slave part (i2c-designware-slave.c)
> 4. Glue drivers (like: i2c-designware-platdrv.c)
>
>> Thanks,
>> Luis
>>
>> On 10/18/2016 16:17, Wolfram Sang wrote:
>>>> This is needed because the configuration is different and the i2c-
>>>> designware
>>>> cannot be master/slave without a reset. To resolve that I added
>>>> this property
>>>> to bind it as a slave when needed.
>>> Aww, pity that the HW can't do that. Do you have details why?
>>>
>>> If that is really a HW limitation, then I'd suggest having a
>>> seperate
>>> driver for slave-only mode so we can differentiate by compatible
>>> strings.
>>>
>>