Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbcKHOVi (ORCPT ); Tue, 8 Nov 2016 09:21:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60024 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbcKHOVf (ORCPT ); Tue, 8 Nov 2016 09:21:35 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() From: "Yan, Zheng" In-Reply-To: Date: Tue, 8 Nov 2016 22:21:30 +0800 Cc: Ilya Dryomov , ceph-devel , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <80D4752E-4A7F-428F-9FDA-A4E6916FF717@redhat.com> References: To: Zhi Zhang X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 08 Nov 2016 14:21:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 37 > On 8 Nov 2016, at 17:16, Zhi Zhang wrote: > > Fix printing wrong return variable for invalidate_inode_pages2_range > in ceph_direct_read_write(). > > Signed-off-by: Zhi Zhang > --- > fs/ceph/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index 18630e8..0136195 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode) > pos >> PAGE_SHIFT, > (pos + count) >> PAGE_SHIFT); > if (ret2 < 0) > - dout("invalidate_inode_pages2_range returned > %d\n", ret); > + dout("invalidate_inode_pages2_range returned > %d\n", ret2); > > flags = CEPH_OSD_FLAG_ORDERSNAP | > CEPH_OSD_FLAG_ONDISK | > > Applied, Thanks Yan, Zheng > Regards, > Zhi Zhang (David) > Contact: zhang.david2011@gmail.com > zhangz.david@outlook.com