Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbcKHOrF (ORCPT ); Tue, 8 Nov 2016 09:47:05 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:47450 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcKHOrD (ORCPT ); Tue, 8 Nov 2016 09:47:03 -0500 Subject: Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip To: Linus Walleij , Axel Haslam , Kevin Hilman References: <20161103113410.2163-1-ahaslam@baylibre.com> CC: Alexandre Courbot , David Lechner , Grygorii Strashko , "J, KEERTHY" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Sekhar Nori Message-ID: Date: Tue, 8 Nov 2016 20:16:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 22 On Tuesday 08 November 2016 07:01 PM, Linus Walleij wrote: > On Thu, Nov 3, 2016 at 12:34 PM, Axel Haslam wrote: > >> The gpiod framework uses the chip label to match a specific chip. >> The davinci gpio driver, creates several chips using always the same >> label, which is not compatible with gpiod. >> >> To allow platform data to declare gpio lookup tables, and for drivers >> to use the gpiod framework, allocate unique label per registered chip. >> >> Signed-off-by: Axel Haslam > > Sekhar/Kevin: can either of you review this patch? The patch looks good to me. Reviewed-by: Sekhar Nori I am traveling and did not really test the patch. Thanks, Sekhar