From: Arnd Bergmann <arnd@arndb.de>
To: John Garry <john.garry@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, Anurup M <anurupvasu@gmail.com>,
        anurup.m@huawei.com, linux-kernel@vger.kernel.org,
        mark.rutland@arm.com, shyju.pv@huawei.com, gabriele.paoloni@huawei.com,
        will.deacon@arm.com, linuxarm@huawei.com, xuwei5@hisilicon.com,
        zhangshaokun@hisilicon.com, sanil.kumar@hisilicon.com,
        tanxiaojun@huawei.com, shiju.jose@huawei.com
Subject: Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver
Date: Tue, 08 Nov 2016 16:10:23 +0100
Message-ID: <1609380.NN50qvVsP7@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <2bac1a34-591b-6557-15bf-40db25c3d129@huawei.com>
References: <1478101374-18778-1-git-send-email-anurup.m@huawei.com> <2030692.HPgjBCTYG6@wuerfel> <2bac1a34-591b-6557-15bf-40db25c3d129@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 558
Lines: 16

On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote:
> 
> Hi Arnd,
> 
> Thanks for the reference.
> 
> I think the i2c interface doesn't fully satisfy our requirements as we 
> need more than just a slave bus address when accessing the slave device 
> (which I think is what i2c uses). We also need to pass "offset" and 
> "mod_mask" arguments to the djtag adapter to access specific registers 
> in the slave device.

Ok. Are those values constant per device, or maybe a range? We may want to
include those in the reg property as well then.

	Arnd