Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753410AbcKHPS7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 10:18:59 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:15164 "EHLO
        szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752325AbcKHPS6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 10:18:58 -0500
Subject: Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon
 Djtag driver
To: Arnd Bergmann <arnd@arndb.de>
References: <1478101374-18778-1-git-send-email-anurup.m@huawei.com>
 <2030692.HPgjBCTYG6@wuerfel>
 <2bac1a34-591b-6557-15bf-40db25c3d129@huawei.com>
 <1609380.NN50qvVsP7@wuerfel>
CC: <linux-arm-kernel@lists.infradead.org>,
        Anurup M <anurupvasu@gmail.com>, <anurup.m@huawei.com>,
        <linux-kernel@vger.kernel.org>, <mark.rutland@arm.com>,
        <shyju.pv@huawei.com>, <gabriele.paoloni@huawei.com>,
        <will.deacon@arm.com>, <linuxarm@huawei.com>, <xuwei5@hisilicon.com>,
        <zhangshaokun@hisilicon.com>, <sanil.kumar@hisilicon.com>,
        <tanxiaojun@huawei.com>, <shiju.jose@huawei.com>
From: John Garry <john.garry@huawei.com>
Message-ID: <4faf6fbc-cbce-f727-4f8a-502b6eb3f406@huawei.com>
Date: Tue, 8 Nov 2016 15:17:45 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1609380.NN50qvVsP7@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.203.181.151]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 690
Lines: 30

On 08/11/2016 15:10, Arnd Bergmann wrote:
> On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote:
>>
>> Hi Arnd,
>>
>> Thanks for the reference.
>>
>> I think the i2c interface doesn't fully satisfy our requirements as we
>> need more than just a slave bus address when accessing the slave device
>> (which I think is what i2c uses). We also need to pass "offset" and
>> "mod_mask" arguments to the djtag adapter to access specific registers
>> in the slave device.
>
> Ok. Are those values constant per device, or maybe a range? We may want to
> include those in the reg property as well then.
>
> 	Arnd
>

Hi Arnd,

I'm not sure, I'll defer to Tan/Anurup.

Cheers,
John

>
> .
>