Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbcKHPsU (ORCPT ); Tue, 8 Nov 2016 10:48:20 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:59181 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbcKHPsP (ORCPT ); Tue, 8 Nov 2016 10:48:15 -0500 From: Arnd Bergmann To: "Y.B. Lu" Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Scott Wood , Mark Rutland , Greg Kroah-Hartman , "X.B. Xie" , "M.H. Lian" , "linux-i2c@vger.kernel.org" , "linux-clk@vger.kernel.org" , Qiang Zhao , Russell King , Bhupesh Sharma , Joerg Roedel , Claudiu Manoil , "devicetree@vger.kernel.org" , Rob Herring , Santosh Shilimkar , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "iommu@lists.linux-foundation.org" , Kumar Gala Subject: Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl Date: Tue, 08 Nov 2016 16:47:00 +0100 Message-ID: <2774358.lRZpWbmlT7@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1477637418-38938-1-git-send-email-yangbo.lu@nxp.com> <1543282.vWjeo4ynTa@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7snuV0WQ2rlNekQ6O3/gqLJ2TNYrfesQ2vRRVaSCN9KXn9Pf5C9 PtKskweCOc9SUKyh3vq0dQ+zCR0rgREvw9aoHR1jKKaSO/dxnVpZ3pNDK8izuhRZNO5gdaG tUYES72zIzv3h/z+MKw5wUsyMV2DcwGTth+QZnjQ6J8AGR6cTunprvg1G9Q4NZ3UZoIJFlg oXW7/7RWizJR7sln7uNyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:xzoBpRUGWE8=:kGfog1XNflQso6ptqODcMi vyBrSXdbY9/ILVtIDs/sd0JIMYzWGr0lixm3bvIkhfwvyItGXjadxSc6R/paNVx6hRq/tE6O/ l3v5tcYVH9uj+WSlRjOvtvAkUjAGp0EpKK+p3hpUL3lOymByuiFn/sOLDwr0Zd6z+VZWqhJbS yQHwhlI0um3Rd37scawa3aUByNK6ktVU7ZHyJ1vALcj/MZzqARXa6so0iv6N32/P8c/k5PiuT lBWOdzTleOy4lDQ/ZPIdBi70MoM4Ls6bY6GicaZfJU1IrEWhPxpf7VYL2p/coUXpf6ZUAQ9rM IJKAj1rgmI2YjxaB5ZZL5xvS+QTmWSliyhH6JmyoZ9xnS9NOz5XSp23BTDs+R8Y8LCxTpMoRj s3Y3svZeqXK6rj3/nrPVYUZoVaFEJ6CXORJ8KCBgO3t+5kAZc26py24Yvri/yJWTXtzR7cT4I Mbr57D+HJDLVXpg1GCN8Ot7y8SiX1K1176FYybYLk3Tsx1ITKvLh6kleHWgioDfE3d+l/FIv4 USeqpQAioyIGts9rSPIiByuIRHr+/jk730sXcaBPYsG6ceHrKfSJvzQJH+0ZxF6berBKSvhB/ GEeF8a4M4HlunYsUn/ttuDn+4QI/w4IcUSaRB2iZmEoGrG72m0+SskUug27rhczAiQdtudxVK 4iwF0zLXJTui/jWnlZECeI0UdY1lCy5Fo6JCJnOpQTDC4kLybODWOXSwk1ErSHQIhkxkQLd08 ZcpA6WAeK3lBE2kF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 47 On Tuesday, November 8, 2016 6:49:51 AM CET Y.B. Lu wrote: > Hi Arnd, > > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > Sent: Tuesday, November 08, 2016 5:20 AM > > To: Y.B. Lu > > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org; > > ulf.hansson@linaro.org; Scott Wood; Mark Rutland; Greg Kroah-Hartman; X.B. > > Xie; M.H. Lian; linux-i2c@vger.kernel.org; linux-clk@vger.kernel.org; > > Qiang Zhao; Russell King; Bhupesh Sharma; Joerg Roedel; Claudiu Manoil; > > devicetree@vger.kernel.org; Rob Herring; Santosh Shilimkar; linux-arm- > > kernel@lists.infradead.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; Leo Li; iommu@lists.linux-foundation.org; Kumar > > Gala > > Subject: Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl > > > > On Monday, October 31, 2016 9:35:33 AM CET Y.B. Lu wrote: > > > > > > > > I don't see any of the contents of this header referenced by the soc > > > > driver any more. I think you can just drop this patch. > > > > > > > > > > [Lu Yangbo-B47093] This header file was included by guts.c. > > > The guts driver used macro SVR_MAJ/SVR_MIN for calculation. > > > > > > This header file was for powerpc arch before. And this patch is to > > > made it as common header file for both ARM and PPC. > > > Sooner or later this is needed. > > > > Let's discuss it once we actually need the header then, ok? > > [Lu Yangbo-B47093] As I said, this header file was included by guts.c in patch 4. Ah sorry, I misread your earlier reply, thinking you meant a potential future patch. > The guts driver used macro SVR_MAJ/SVR_MIN for calculation which were > defined in this header file. > Did you suggest we dropped this patch and just calculated them in driver? That is probably nicer here: there is not that much value in sharing the two one-line macro definitions, and the driver already hardcodes the numeric per-chip IDs that make up most of the header file. Arnd