Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932521AbcKHQQw (ORCPT ); Tue, 8 Nov 2016 11:16:52 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33861 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbcKHQQq (ORCPT ); Tue, 8 Nov 2016 11:16:46 -0500 Date: Tue, 8 Nov 2016 17:16:41 +0100 From: Daniel Vetter To: Liviu Dudau Cc: DRI devel , Mali DP Maintainers , LKML Subject: Re: [PATCH] drm: mali-dp: Add support for setting plane's rotation property from userspace. Message-ID: <20161108161641.haxmqzwkktw3wrfx@phenom.ffwll.local> Mail-Followup-To: Liviu Dudau , DRI devel , Mali DP Maintainers , LKML References: <20161108134325.1466-1-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161108134325.1466-1-Liviu.Dudau@arm.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 41 On Tue, Nov 08, 2016 at 01:43:25PM +0000, Liviu Dudau wrote: > In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property > we need to have a ->set_property hook defined for the planes. Set the > plane's ->set_property hook to drm_atomic_helper_plane_set_property() > > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/arm/malidp_planes.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c > index bb1c528..8eef9a8 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -89,6 +89,7 @@ void malidp_destroy_plane_state(struct drm_plane *plane, > static const struct drm_plane_funcs malidp_de_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > + .set_property = drm_atomic_helper_plane_set_property, We discussed this a bit, I think it'd be nice to simply make this the default for all atomic drivers (and demote all the set_prop helpers from exported helpers to internal static functions). But can be done as a cleanup later on, ack for this patch meanwhile. -Daniel > .destroy = malidp_de_plane_destroy, > .reset = drm_atomic_helper_plane_reset, > .atomic_duplicate_state = malidp_duplicate_plane_state, > -- > 2.10.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch