From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        James Bottomley <jejb@linux.vnet.ibm.com>
CC: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@infradead.org>,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation
Thread-Topic: [PATCH] libfc: fix seconds_since_last_reset miscalculation
Thread-Index: AQHSOZxoB4rqxR59R0+2RX5K3eLbrQ==
Date: Tue, 8 Nov 2016 15:04:43 +0000
Message-ID: <BLUPR02MB16830DECB29262BACBA94FA681A60@BLUPR02MB1683.namprd02.prod.outlook.com>
References: <1478594694-98847-1-git-send-email-jthumshirn@suse.de>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2016 15:04:43.2945
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1681
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA8GcovY008815
Content-Length: 1957
Lines: 53

On 11/08/16 00:45, Johannes Thumshirn wrote:
> Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation'
> removed the use of 'struct timespec' from fc_get_host_stats(). This broke the
> output of 'fcoeadm -s' after kernel 4.8-rc1 as lport->boot_time - jiffies
> could become negative as in this example:
>
> $ cat /sys/class/fc_host/host8/statistics/seconds_since_last_reset
> 0x10624dd2f1977b4
>
> Take this into account so
> /sys/class/fc_host/hostX/statistics/seconds_since_last_reset is sane again.
>
> Fixes: 540eb1eef ('scsi: libfc: fix seconds_since_last_reset calculation')
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Tested-by: Holger Schranz <holger@fam-schranz.de>
> ---
>  drivers/scsi/libfc/fc_lport.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
> index 04ce7cf..475c0a9 100644
> --- a/drivers/scsi/libfc/fc_lport.c
> +++ b/drivers/scsi/libfc/fc_lport.c
> @@ -304,11 +304,15 @@ struct fc_host_statistics *fc_get_host_stats(struct Scsi_Host *shost)
>  	unsigned int cpu;
>  	u64 fcp_in_bytes = 0;
>  	u64 fcp_out_bytes = 0;
> +	unsigned long boot_time = lport->boot_time;
>
>  	fc_stats = &lport->host_stats;
>  	memset(fc_stats, 0, sizeof(struct fc_host_statistics));
>
> -	fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ;
> +	if (boot_time > jiffies)
> +		fc_stats->seconds_since_last_reset = (boot_time - jiffies) / HZ;
> +	else
> +		fc_stats->seconds_since_last_reset = (jiffies - boot_time) / HZ;
>
>  	for_each_possible_cpu(cpu) {
>  		struct fc_stats *stats;

Hello Johannes,

I think the above code will miscalculate seconds_since_last_reset if 
'jiffies' wraps around after an lport has been created and before 
seconds_since_last_reset is computed. Shouldn't seconds_since_last_reset 
be computed as follows?

	fc_stats->seconds_since_last_reset = (jiffies - boot_time) / HZ;

Bart.