Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933235AbcKHQus (ORCPT ); Tue, 8 Nov 2016 11:50:48 -0500 Received: from canardo.mork.no ([148.122.252.1]:51469 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932301AbcKHQuo (ORCPT ); Tue, 8 Nov 2016 11:50:44 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Alan Stern Cc: Kai-Heng Feng , Oliver Neukum , , , Subject: Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function Organization: m References: Date: Tue, 08 Nov 2016 17:49:21 +0100 In-Reply-To: (Alan Stern's message of "Tue, 8 Nov 2016 10:25:26 -0500 (EST)") Message-ID: <87eg2lkjce.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA8Gp35D009060 Content-Length: 2313 Lines: 60 Alan Stern writes: > On Tue, 8 Nov 2016, Kai-Heng Feng wrote: > >> Hi, >> >> On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: >> > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> >> [ 9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 >> >> >> >> This can be solved by increase its pm usage counter. >> >> >> >> Signed-off-by: Kai-Heng Feng >> > >> > For the record: >> > >> > NAK. This fixes a symptom. If this patch helps something is broken in >> > device core. We need to find that. >> > >> >> Please check attached dmesg with usbcore.dyndbg="+p". > > The log shows that the device went into suspend _before_ the cdc_mbim > driver was probed, not during the probe. Then just before the probe > was started, the USB core tried to resume the device and the resume > failed. > > The log shows a bunch of other problems with this device: > > [ 3.862253] usb 2-2: config 1 has an invalid interface number: 12 but max is 1 > [ 3.862254] usb 2-2: config 1 has an invalid interface number: 13 but max is 1 > [ 3.862254] usb 2-2: config 1 has an invalid interface number: 13 but max is 1 > [ 3.862255] usb 2-2: config 1 has no interface number 0 > [ 3.862256] usb 2-2: config 1 has no interface number 1 These messages are completely harmless and normal for Sierra Wireless devices. They use the interface number to identify the type of function, causing this mismatch between the number of interfaces and the inteface numbers. Boy, that looks weird in writing :) Ref this discussion we had a few years ago: http://www.spinics.net/lists/linux-usb/msg77499.html No, I didn't expect you to remember that :) > [ 8.295180] usb 2-2: Disable of device-initiated U1 failed. > [ 8.295322] usb 2-2: Disable of device-initiated U2 failed. > > I get the impression that the device won't work properly with runtime > PM at all. I suspect the device is an EM7455? If so, then it does work fine with runtime PM, as long as we're talking USB2. Not sure about USB3 runtime PM though. Cannot test it. The Lenovo laptop I got with one of these modems has disabled the USB3 link on the m.2 modem slot for some reason. Bjørn