Date: Tue, 8 Nov 2016 16:44:36 +0000
From: Liviu Dudau <Liviu.Dudau@arm.com>
To: DRI devel <dri-devel@lists.freedesktop.org>,
        Mali DP Maintainers <malidp@foss.arm.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: mali-dp: Add support for setting plane's rotation
 property from userspace.
Message-ID: <20161108164436.GC10219@e106497-lin.cambridge.arm.com>
References: <20161108134325.1466-1-Liviu.Dudau@arm.com>
 <20161108161641.haxmqzwkktw3wrfx@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161108161641.haxmqzwkktw3wrfx@phenom.ffwll.local>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2094
Lines: 59

On Tue, Nov 08, 2016 at 05:16:41PM +0100, Daniel Vetter wrote:
> On Tue, Nov 08, 2016 at 01:43:25PM +0000, Liviu Dudau wrote:
> > In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property
> > we need to have a ->set_property hook defined for the planes. Set the
> > plane's ->set_property hook to drm_atomic_helper_plane_set_property()
> > 
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > ---
> >  drivers/gpu/drm/arm/malidp_planes.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> > index bb1c528..8eef9a8 100644
> > --- a/drivers/gpu/drm/arm/malidp_planes.c
> > +++ b/drivers/gpu/drm/arm/malidp_planes.c
> > @@ -89,6 +89,7 @@ void malidp_destroy_plane_state(struct drm_plane *plane,
> >  static const struct drm_plane_funcs malidp_de_plane_funcs = {
> >  	.update_plane = drm_atomic_helper_update_plane,
> >  	.disable_plane = drm_atomic_helper_disable_plane,
> > +	.set_property = drm_atomic_helper_plane_set_property,
> 
> We discussed this a bit, I think it'd be nice to simply make this the
> default for all atomic drivers (and demote all the set_prop helpers from
> exported helpers to internal static functions). But can be done as a
> cleanup later on, ack for this patch meanwhile.

Thanks for the ACK! Yes, I will work on the cleanup and fix all other affected
drivers as well, this is my attempt to get the patches into v4.9 ;)

Best regards,
Liviu

> -Daniel
> 
> >  	.destroy = malidp_de_plane_destroy,
> >  	.reset = drm_atomic_helper_plane_reset,
> >  	.atomic_duplicate_state = malidp_duplicate_plane_state,
> > -- 
> > 2.10.0
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯