Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933350AbcKHRHB (ORCPT ); Tue, 8 Nov 2016 12:07:01 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:55553 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbcKHRG7 (ORCPT ); Tue, 8 Nov 2016 12:06:59 -0500 Date: Tue, 8 Nov 2016 18:04:22 +0100 (CET) From: Thomas Gleixner To: Kan Liang cc: Peter Zijlstra , mingo@redhat.com, LKML , eranian@google.com, benjamin.widawsky@intel.com, Andi Kleen , "H. Peter Anvin" Subject: Re: [PATCH] perf/x86: add more Intel uncore IMC PCI ID for SkyLake In-Reply-To: <1478555231-20143-1-git-send-email-kan.liang@intel.com> Message-ID: References: <1478555231-20143-1-git-send-email-kan.liang@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 42 On Mon, 7 Nov 2016, kan.liang@intel.com wrote: > There are several PCI IDs are missed for Intel SkyLake IMC. There are ... are ??? > This patch adds the PCI IDs for SkyLake Y, U, H and S platforms. "This patch" is just a bad habit. We already know that this is a patch. See Documentation/SubmittingPatches, which has an explanation for this. > This patch also rename 0x191f and 0x190c according to the document. You do not rename the hex constants. You rename the ID macros ... > These PCI IDs are defined in the document as below. > > Y & U platforms > http://www.intel.com/content/www/us/en/processors/core/ > 6th-gen-core-family-mobile-u-y-processor-lines-datasheet-vol-2.html > > S platform > http://www.intel.com/content/www/us/en/processors/core/ > desktop-6th-gen-core-family-datasheet-vol-2.html > > H platform > http://www.intel.com/content/www/us/en/processors/core/ > 6th-gen-core-family-mobile-h-processor-lines-datasheet-vol-2.html As I said before several times. These links are just horrible. The Intel webpage is restructured every so often, so the links might be stale before thishits Linus tree. We really need persistant links, not just the link of today. One way to achive that is to open a bugzilla entry in the kernel org bugzilla and stick the files there for permanent reference, unless Intel comes up with something which is not affected by their constant web page reshuffling. Thanks, tglx