Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933170AbcKHRau (ORCPT ); Tue, 8 Nov 2016 12:30:50 -0500 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:48828 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbcKHRas (ORCPT ); Tue, 8 Nov 2016 12:30:48 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 08 Nov 2016 18:30:46 +0100 X-ME-IP: 109.222.248.68 From: Robert Jarzmik To: Arnd Bergmann Cc: Greg Kroah-Hartman , Jiri Slaby , Sergey Yanovich , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused In-Reply-To: <20161108145130.3502815-2-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 8 Nov 2016 15:50:42 +0100") References: <20161108145130.3502815-1-arnd@arndb.de> <20161108145130.3502815-2-arnd@arndb.de> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) X-URL: http://belgarath.falguerolles.org/ Date: Tue, 08 Nov 2016 18:30:43 +0100 Message-ID: <87shr1yj3w.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 19 Arnd Bergmann writes: > The fresh new serial driver for pxa produces warnings when > CONFIG_PM_SLEEP is disabled: > > drivers/tty/serial/8250/8250_pxa.c:50:12: error: 'serial_pxa_resume' defined but not used [-Werror=unused-function] > drivers/tty/serial/8250/8250_pxa.c:41:12: error: 'serial_pxa_suspend' defined but not used [-Werror=unused-function] > > This removes the #ifdef around the two functions and instead marks both > as __maybe_unused, which is more robust and avoids the warning. > > Fixes: ab28f51c77cd ("serial: rewrite pxa2xx-uart to use 8250_core") > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert