Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933334AbcKHRkS (ORCPT ); Tue, 8 Nov 2016 12:40:18 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50924 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754038AbcKHRkR (ORCPT ); Tue, 8 Nov 2016 12:40:17 -0500 Date: Tue, 8 Nov 2016 17:40:05 +0000 From: Mark Brown To: Chris Brandt Cc: Arnd Bergmann , Hiep Cao Minh , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Message-ID: <20161108174005.mjxbvgbjjxmakhur@sirena.org.uk> References: <20161108134624.1905209-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oi6tp3tg6dayiksn" Content-Disposition: inline In-Reply-To: X-Cookie: A bachelor is an unaltared male. User-Agent: NeoMutt/20161014 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: rspi: avoid uninitialized variable access X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 34 --oi6tp3tg6dayiksn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 08, 2016 at 05:20:50PM +0000, Chris Brandt wrote: > Since I was CC-ed, I'll add in my opinion: > While Geert already pointed out the spelling mistake (_in_or_our >> _in_or_out), since that function is only just for qspi versions, a better function name should have been "qspi_pio_transfer_in_or_out" Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. --oi6tp3tg6dayiksn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJYIg3xAAoJECTWi3JdVIfQP9wH/0i8KJBueVo1SsEsT/UcHr0U 6YoNccSIMXwY8CQkbOwckgGhl2fAWyszulcz2aXqZ29xdJRi7lXVLr/Y5NhUrGb5 8+/igFrIsua698nR2j1X6Ecy4H4nCprsNECrV0aMjLlo0L3hvjps4rhY4b/EYCAA KbucHrDH2/05D+W3yAurYLeQI94fcz7C0BmiCqJokpQQW+4WSFyUYYoz7mI+Om4I EDeGEee2TEDCB+jK+jaYKkIzv50dluL8t87IwOmxxvmcgY1x/Hero9+hy5iiFlCZ BiIMq5QwzV1q+y6FBNT6Ml6Mg6J1OcdgZCc8fOofTBGxAJyiYadVZ2ppAwT93HI= =7nyL -----END PGP SIGNATURE----- --oi6tp3tg6dayiksn--