Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754127AbcKHRu7 (ORCPT ); Tue, 8 Nov 2016 12:50:59 -0500 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:22682 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753997AbcKHRu6 (ORCPT ); Tue, 8 Nov 2016 12:50:58 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 08 Nov 2016 18:50:45 +0100 X-ME-IP: 109.222.248.68 From: Robert Jarzmik To: Arnd Bergmann Cc: Stephen Boyd , Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' References: <20161108144950.3472058-1-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 08 Nov 2016 18:50:44 +0100 In-Reply-To: <20161108144950.3472058-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 8 Nov 2016 15:49:30 +0100") Message-ID: <87oa1pyi6j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 Arnd Bergmann writes: > The dummy_clk_set_parent function is marked as 'static' but is > no longer referenced from the pxa25x clk driver after the last use > of the RATE_RO_OPS() macro is gone from this file, causing a > harmless build warning: > > In file included from drivers/clk/pxa/clk-pxa25x.c:24:0: > drivers/clk/pxa/clk-pxa.h:146:12: error: 'dummy_clk_set_parent' defined but not used [-Werror=unused-function] > > This marks the functon as 'inline', which lets the compiler simply > drop it when it gets referenced. > > Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq") > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert