Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932629AbcKHSfZ (ORCPT ); Tue, 8 Nov 2016 13:35:25 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35430 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcKHSfW (ORCPT ); Tue, 8 Nov 2016 13:35:22 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161108134624.1905209-1-arnd@arndb.de> From: Geert Uytterhoeven Date: Tue, 8 Nov 2016 19:35:20 +0100 X-Google-Sender-Auth: xd5ik8Q1TEY7mFHkFN5m6npp9w4 Message-ID: Subject: Re: [PATCH] spi: rspi: avoid uninitialized variable access To: Chris Brandt Cc: Arnd Bergmann , Mark Brown , Hiep Cao Minh , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 27 On Tue, Nov 8, 2016 at 6:20 PM, Chris Brandt wrote: > However.... > > On 11/8/2016, Arnd Bergmann wrote: >> This simplifies it again by keeping the two separate, which then ends up >> avoiding that warning. > > I agree with Arnd's method of NOT adding a new "rspi_pio_transfer_in_or_our" > function and instead just doing it in the existing qspi_transfer_ functions. > > Side note: The RSPI in the RZ/A1 devices also have FIFOs which can be used > to reduce the number of interrupts in pio transfers, so maybe someday I'll > make a similar change for non-qspi devices as well. At which point we probably want to extract the functionality into two separate functions again, instead of inlining into qspi_transfer_{in,out}()... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds