Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932545AbcKHULd (ORCPT ); Tue, 8 Nov 2016 15:11:33 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:37823 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937AbcKHULR (ORCPT ); Tue, 8 Nov 2016 15:11:17 -0500 Date: Tue, 8 Nov 2016 21:11:14 +0100 From: Peter Zijlstra To: Zhi Li Cc: Paul Gortmaker , Frank Li , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , LKML , Ingo Molnar , acme@kernel.org, alexander.shishkin@linux.intel.com, Mark Rutland , jerry shen , Zhengyu Shen Subject: Re: [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver Message-ID: <20161108201114.GQ3117@twins.programming.kicks-ass.net> References: <1474307267-3081-1-git-send-email-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 440 Lines: 13 On Tue, Nov 08, 2016 at 01:21:47PM -0600, Zhi Li wrote: > On Tue, Nov 8, 2016 at 1:00 PM, Paul Gortmaker > > I just noticed this commit now that linux-next is back after the week off. > > > > This should probably use core_param or setup_param since the Kconfig > > for this is bool and not tristate. > I think pmu_pmu_poll_period_us should be removed because no benefit to > change it. > I can delete .remove Why not make it tristate ?