Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933621AbcKHUaX (ORCPT ); Tue, 8 Nov 2016 15:30:23 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33621 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933110AbcKHUaU (ORCPT ); Tue, 8 Nov 2016 15:30:20 -0500 Subject: Re: [PATCH v4 1/3] leds: Introduce userspace leds driver To: David Lechner , Jacek Anaszewski , Richard Purdie References: <1474053410-24387-1-git-send-email-david@lechnology.com> <1474053410-24387-2-git-send-email-david@lechnology.com> <0bfdfd46-35e5-321c-5759-0cc96be862fd@samsung.com> <0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com> Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Marcel Holtmann , Pavel Machek From: Jacek Anaszewski Message-ID: Date: Tue, 8 Nov 2016 21:29:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 34 On 11/08/2016 08:08 PM, David Lechner wrote: > > > On 11/8/16 5:26 AM, Jacek Anaszewski wrote: >> Hi David, >> > >>> +struct uleds_device { >>> + struct uleds_user_dev user_dev; >>> + struct led_classdev led_cdev; >>> + struct mutex mutex; >>> + enum uleds_state state; >>> + wait_queue_head_t waitq; >>> + unsigned char brightness; >> >> I've just noticed that this is wrong, since LED subsystem >> brightness type is enum led_brightness, i.e. int. >> LED_FULL (255) value is a legacy enum value that can be overridden >> by max_brightness property. >> >> Please submit a fix so that I could merge it with the original >> patch before sending it upstream. >> >> Thanks, >> Jacek Anaszewski >> > > The brightness should be a 32-bit integer then? Exactly. -- Best regards, Jacek Anaszewski