Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933654AbcKHUpP (ORCPT ); Tue, 8 Nov 2016 15:45:15 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8101 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754357AbcKHUpN (ORCPT ); Tue, 8 Nov 2016 15:45:13 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 08 Nov 2016 12:45:11 -0800 Subject: Re: [PATCH v11 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare() To: Alexey Kardashevskiy , , , , References: <1478293856-8191-1-git-send-email-kwankhede@nvidia.com> <1478293856-8191-18-git-send-email-kwankhede@nvidia.com> CC: , , , , , X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <0952b8ae-7d44-2239-fed4-aa9e2b89483c@nvidia.com> Date: Wed, 9 Nov 2016 02:11:04 +0530 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.24.70.42] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2773 Lines: 94 On 11/8/2016 2:22 PM, Alexey Kardashevskiy wrote: > On 05/11/16 08:10, Kirti Wankhede wrote: >> Updated vfio_platform_common.c file to use >> vfio_set_irqs_validate_and_prepare() >> >> Signed-off-by: Kirti Wankhede >> Signed-off-by: Neo Jia >> Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 >> --- >> drivers/vfio/platform/vfio_platform_common.c | 31 +++++++--------------------- >> 1 file changed, 8 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c >> index d78142830754..4c27f4be3c3d 100644 >> --- a/drivers/vfio/platform/vfio_platform_common.c >> +++ b/drivers/vfio/platform/vfio_platform_common.c >> @@ -364,36 +364,21 @@ static long vfio_platform_ioctl(void *device_data, >> struct vfio_irq_set hdr; >> u8 *data = NULL; >> int ret = 0; >> + size_t data_size = 0; >> >> minsz = offsetofend(struct vfio_irq_set, count); >> >> if (copy_from_user(&hdr, (void __user *)arg, minsz)) >> return -EFAULT; >> >> - if (hdr.argsz < minsz) >> - return -EINVAL; >> - >> - if (hdr.index >= vdev->num_irqs) >> - return -EINVAL; >> - >> - if (hdr.flags & ~(VFIO_IRQ_SET_DATA_TYPE_MASK | >> - VFIO_IRQ_SET_ACTION_TYPE_MASK)) >> - return -EINVAL; >> - >> - if (!(hdr.flags & VFIO_IRQ_SET_DATA_NONE)) { >> - size_t size; >> - >> - if (hdr.flags & VFIO_IRQ_SET_DATA_BOOL) >> - size = sizeof(uint8_t); >> - else if (hdr.flags & VFIO_IRQ_SET_DATA_EVENTFD) >> - size = sizeof(int32_t); >> - else >> - return -EINVAL; >> - >> - if (hdr.argsz - minsz < size) >> - return -EINVAL; >> + ret = vfio_set_irqs_validate_and_prepare(&hdr, vdev->num_irqs, >> + vdev->num_irqs, &data_size); > > The patch does not change this but I am still curious: > > is not the second vdev->num_irqs supposed to be one of > VFIO_PCI_INTX_IRQ_INDEX..VFIO_PCI_NUM_IRQS, not the actual number of > interrupt vectors (as in vfio-pci)? > > Those are PCI specific. I don't think those counts are applicable here. If you see the prototype, second argument and third argument have different meaning. int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, int num_irqs, int max_irq_type, size_t *data_size) - num_irqs are number of irqs caller want to setup and - max_irq_type is the one which is return to user in VFIO_DEVICE_GET_INFO ioctl's info.num_irqs. For platform these two are same. Thanks, Kirti > > >> + if (ret) >> + return ret; >> >> - data = memdup_user((void __user *)(arg + minsz), size); >> + if (data_size) { >> + data = memdup_user((void __user *)(arg + minsz), >> + data_size); >> if (IS_ERR(data)) >> return PTR_ERR(data); >> } >> > >