Date: Tue, 8 Nov 2016 23:24:20 +0100
From: Lukasz Majewski <l.majewski@majess.pl>
To: Thierry Reding <thierry.reding@gmail.com>,
        Stefan Agner <stefan@agner.ch>, Sascha Hauer <s.hauer@pengutronix.de>,
        Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Lothar Wassmann <LW@karo-electronics.de>,
        Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>, kernel@pengutronix.de
Subject: Re: [PATCH v3 00/11] pwm: imx: Provide atomic operation for IMX PWM
 driver
Message-ID: <20161108232420.307400b7@jawa>
In-Reply-To: <1477984230-18071-1-git-send-email-l.majewski@majess.pl>
References: <1477984230-18071-1-git-send-email-l.majewski@majess.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 boundary="Sig_/dhHVrWVjNam.CyFvU0S/9Bv"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2860
Lines: 91

--Sig_/dhHVrWVjNam.CyFvU0S/9Bv
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Dear All,

> This patch set brings atomic operation to i.MX's PWMv2 driver.

Are there any more comments regarding this patch set?

Best regards,
=C5=81ukasz Majewski

>=20
> This work has been supported and suggested by Boris Brezillon [1] and=20
> Stefan Agner, by showing how simple the transition could be :-).
>=20
> It has been divided into several steps:
>=20
> - Remove ipg clock enable/disable code (as proposed by Sascha Hauer)
> - this is the most notable change for v3
>=20
> - Provide different pwm ops for PWMv1 and PWMv2
>=20
> - Separate PWMv1 commits from "generic" and non atomic PWM code
>=20
>   NOTE: Since I do _not_ have board with PWMv1, I would like to ask
> somebody for testing
>=20
> - Move some imx_config_v2 code to separate functions
>=20
> - Provide PWM atomic implementation (the ->apply() driver) for PWMv2
> in a single patch for better readability.
>=20
> - Remove redundant PWM code (disable, enable, config callbacks)
>=20
> - Update proper documentation entries
>=20
> - Provide support for polarity inversion on top of atomic PWM rework
>=20
> Test HW:
> --------
> This patch set has been tested on i.MX6q board with
> v4.9-rc3 kernel SHA1: a909d3e636995ba7c349e2ca5dbb528154d4ac30
>=20
>=20
> The PWM operation has been tested with pwm_bl backlight driver by
> changing its brightness.
>=20
> [1]: http://patchwork.ozlabs.org/patch/685402/
>=20
>=20
> Lothar Wassmann (2):
>   pwm: print error messages with pr_err() instead of pr_debug()
>   pwm: core: make the PWM_POLARITY flag in DTB optional
>=20
> Lukasz Majewski (8):
>   pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2
>   pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic
> pwm operation
>   pwm: imx: Move PWMv2 software reset code to a separate function
>   pwm: imx: Move PWMv2 wait for fifo slot code to a separate function
>   pwm: imx: Provide atomic PWM support for i.MX PWMv2
>   pwm: imx: Remove redundant i.MX PWMv2 code
>   pwm: imx: doc: Update imx-pwm.txt documentation entry
>   pwm: imx: Add polarity inversion support to i.MX's PWMv2
>=20
> Sascha Hauer (1):
>   pwm: imx: remove ipg clock
>=20
>  Documentation/devicetree/bindings/pwm/imx-pwm.txt |   6 +-
>  drivers/pwm/core.c                                |  26 +--
>  drivers/pwm/pwm-imx.c                             | 247
> ++++++++++------------ 3 files changed, 134 insertions(+), 145
> deletions(-)
>=20


--Sig_/dhHVrWVjNam.CyFvU0S/9Bv
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlgiUJsACgkQf9/hG2YwgjES+gCeLD85ybXPZnZ7QLQLRlyvbmTN
f3kAn33MShylwSB06EZTx4+hi66Ev58N
=Hfpc
-----END PGP SIGNATURE-----

--Sig_/dhHVrWVjNam.CyFvU0S/9Bv--