Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbcKHWnE (ORCPT ); Tue, 8 Nov 2016 17:43:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56562 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcKHWnB (ORCPT ); Tue, 8 Nov 2016 17:43:01 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 331B4612BD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 8 Nov 2016 14:42:59 -0800 From: Stephen Boyd To: Arnd Bergmann Cc: Michael Turquette , Robert Jarzmik , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Message-ID: <20161108224259.GL16026@codeaurora.org> References: <20161108144950.3472058-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161108144950.3472058-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 26 On 11/08, Arnd Bergmann wrote: > The dummy_clk_set_parent function is marked as 'static' but is > no longer referenced from the pxa25x clk driver after the last use > of the RATE_RO_OPS() macro is gone from this file, causing a > harmless build warning: > > In file included from drivers/clk/pxa/clk-pxa25x.c:24:0: > drivers/clk/pxa/clk-pxa.h:146:12: error: 'dummy_clk_set_parent' defined but not used [-Werror=unused-function] > > This marks the functon as 'inline', which lets the compiler simply > drop it when it gets referenced. > > Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq") I hope I don't rewrite clk-next history... I need some sort of magic git pre-commit hook that rewrites fixes tags if the hash changes. > Signed-off-by: Arnd Bergmann > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project