Message-ID: <87oa1pscne.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
CC: Archit Taneja <architt@codeaurora.org>,
        Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
        Fabio Estevam <fabio.estevam@freescale.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
        Thierry Reding <treding@nvidia.com>,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>,
        <linux-renesas-soc@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>, Jose Abreu <joabreu@synopsys.com>
Subject: Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support
In-Reply-To: <20161108111009.GO1041@n2100.armlinux.org.uk>
References: <8737j2bxba.wl%kuninori.morimoto.gx@renesas.com>
        <20161108111009.GO1041@n2100.armlinux.org.uk>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Wed, 9 Nov 2016 00:47:36 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2016 00:47:36.4507 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1446
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 682
Lines: 23


Hi Russell

> > @@ -11,4 +11,11 @@ struct dw_hdmi_audio_data {
> >  	u8 *eld;
> >  };
> >  
> > +struct dw_hdmi_i2s_audio_data {
> > +	struct dw_hdmi *hdmi;
> > +
> > +	void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
> > +	u8 (*read)(struct dw_hdmi *hdmi, int offset);
> > +};
> 
> Another slight concern here is why we need this separate data for i2s -
> maybe adding the write/read ops to struct dw_hdmi_audio_data would be
> a better thing to do, which would then allow the AHB audio to drop
> the .base argument in the future.
> 
> I'm not that bothered about this though.  So...

Thank you for your feedback.
Maybe we can merge these in incremental patch if needed ?