Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbcKIHfx (ORCPT ); Wed, 9 Nov 2016 02:35:53 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34812 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcKIHfu (ORCPT ); Wed, 9 Nov 2016 02:35:50 -0500 Date: Wed, 9 Nov 2016 15:35:44 +0800 From: Zhiyi Sun To: bblanco@plumgrid.com, Tariq Toukan , Yishai Hadas , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: zhiyisun@gmail.com Subject: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4 Message-ID: <20161109073544.jbufjqn7y7oa6ptg@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 32 There are rx_ring_num queues. Each queue will load xdp prog. So bpf_prog_add() should add rx_ring_num to ref_cnt. Signed-off-by: Zhiyi Sun --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index 12c99a2..d25e150 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -2650,7 +2650,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) */ if (priv->xdp_ring_num == xdp_ring_num) { if (prog) { - prog = bpf_prog_add(prog, priv->rx_ring_num - 1); + prog = bpf_prog_add(prog, priv->rx_ring_num); if (IS_ERR(prog)) return PTR_ERR(prog); } @@ -2680,7 +2680,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) } if (prog) { - prog = bpf_prog_add(prog, priv->rx_ring_num - 1); + prog = bpf_prog_add(prog, priv->rx_ring_num); if (IS_ERR(prog)) return PTR_ERR(prog); } -- 2.9.3